summaryrefslogtreecommitdiffstats
path: root/helpers
diff options
context:
space:
mode:
authorDaniel TISCHER <dos.7182@gmail.com>2015-11-25 23:03:28 +0100
committerSteve Francia <steve.francia@gmail.com>2016-01-01 14:35:58 -0500
commit40fccf2251a7187f002165653d42178e2f53a49b (patch)
tree9c49e21294576d9adb7d393e94690e45928253b9 /helpers
parentb56362defd8f067a1bab2f5502e851dfd9311ec2 (diff)
Fixes #1292
Diffstat (limited to 'helpers')
-rw-r--r--helpers/path.go2
-rw-r--r--helpers/path_test.go8
-rw-r--r--helpers/url_test.go2
3 files changed, 7 insertions, 5 deletions
diff --git a/helpers/path.go b/helpers/path.go
index 757cedefb..bab6c71f9 100644
--- a/helpers/path.go
+++ b/helpers/path.go
@@ -96,7 +96,7 @@ func UnicodeSanitize(s string) string {
target := make([]rune, 0, len(source))
for _, r := range source {
- if unicode.IsLetter(r) || unicode.IsDigit(r) || unicode.IsMark(r) || r == '.' || r == '/' || r == '\\' || r == '_' || r == '-' || r == '#' {
+ if unicode.IsLetter(r) || unicode.IsDigit(r) || unicode.IsMark(r) || r == '%' || r == '.' || r == '/' || r == '\\' || r == '_' || r == '-' || r == '#' {
target = append(target, r)
}
}
diff --git a/helpers/path_test.go b/helpers/path_test.go
index 7718730c6..53848b0b5 100644
--- a/helpers/path_test.go
+++ b/helpers/path_test.go
@@ -40,13 +40,14 @@ func TestMakePath(t *testing.T) {
}{
{" Foo bar ", "Foo-bar", true},
{"Foo.Bar/foo_Bar-Foo", "Foo.Bar/foo_Bar-Foo", true},
- {"fOO,bar:foo%bAR", "fOObarfoobAR", true},
+ {"fOO,bar:foobAR", "fOObarfoobAR", true},
{"FOo/BaR.html", "FOo/BaR.html", true},
{"трям/трям", "трям/трям", true},
{"은행", "은행", true},
{"Банковский кассир", "Банковскии-кассир", true},
// Issue #1488
{"संस्कृत", "संस्कृत", false},
+ {"a%C3%B1ame", "a%C3%B1ame", false}, // Issue #1292
}
for _, test := range tests {
@@ -68,7 +69,7 @@ func TestMakePathSanitized(t *testing.T) {
}{
{" FOO bar ", "foo-bar"},
{"Foo.Bar/fOO_bAr-Foo", "foo.bar/foo_bar-foo"},
- {"FOO,bar:Foo%Bar", "foobarfoobar"},
+ {"FOO,bar:FooBar", "foobarfoobar"},
{"foo/BAR.HTML", "foo/bar.html"},
{"трям/трям", "трям/трям"},
{"은행", "은행"},
@@ -93,7 +94,7 @@ func TestMakePathSanitizedDisablePathToLower(t *testing.T) {
}{
{" FOO bar ", "FOO-bar"},
{"Foo.Bar/fOO_bAr-Foo", "Foo.Bar/fOO_bAr-Foo"},
- {"FOO,bar:Foo%Bar", "FOObarFooBar"},
+ {"FOO,bar:FooBar", "FOObarFooBar"},
{"foo/BAR.HTML", "foo/BAR.HTML"},
{"трям/трям", "трям/трям"},
{"은행", "은행"},
@@ -771,6 +772,7 @@ func TestGetTempDir(t *testing.T) {
{testDir + " Foo bar ", dir + testDir + " Foo bar " + FilePathSeparator},
{testDir + "Foo.Bar/foo_Bar-Foo", dir + testDir + "Foo.Bar/foo_Bar-Foo" + FilePathSeparator},
{testDir + "fOO,bar:foo%bAR", dir + testDir + "fOObarfoo%bAR" + FilePathSeparator},
+ {testDir + "fOO,bar:foobAR", dir + testDir + "fOObarfoobAR" + FilePathSeparator},
{testDir + "FOo/BaR.html", dir + testDir + "FOo/BaR.html" + FilePathSeparator},
{testDir + "трям/трям", dir + testDir + "трям/трям" + FilePathSeparator},
{testDir + "은행", dir + testDir + "은행" + FilePathSeparator},
diff --git a/helpers/url_test.go b/helpers/url_test.go
index 632a0f8a9..c484a99a6 100644
--- a/helpers/url_test.go
+++ b/helpers/url_test.go
@@ -28,7 +28,7 @@ func TestURLize(t *testing.T) {
}{
{" foo bar ", "foo-bar"},
{"foo.bar/foo_bar-foo", "foo.bar/foo_bar-foo"},
- {"foo,bar:foo%bar", "foobarfoobar"},
+ {"foo,bar:foobar", "foobarfoobar"},
{"foo/bar.html", "foo/bar.html"},
{"трям/трям", "%D1%82%D1%80%D1%8F%D0%BC/%D1%82%D1%80%D1%8F%D0%BC"},
}