diff options
| author | Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> | 2021-12-23 12:46:04 +0100 |
|---|---|---|
| committer | Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> | 2021-12-23 16:23:15 +0100 |
| commit | 623dda71747c58dd052dbde3a0dbed1fb75b0c41 (patch) | |
| tree | 3449eb3386f533438b6155b7cba6bcebef90fe6b /config/security/securityonfig_test.go | |
| parent | aee9e11a400ac231eb9e91c005f1fe039b106396 (diff) | |
Revert "config/security: Add HOME to default exec env var whitelist"
There have been one report in the wild suggesting that this needs to be tested better before doing:
https://discourse.gohugo.io/t/hugo-mod-failing-in-v0-91-1-but-works-in-v0-91-0/36180/5
This reverts commit fca266ebbb81af3d4479873a7a79759033c7ce25.
Diffstat (limited to 'config/security/securityonfig_test.go')
| -rw-r--r-- | config/security/securityonfig_test.go | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/config/security/securityonfig_test.go b/config/security/securityonfig_test.go index bafb4e766..d0416a20d 100644 --- a/config/security/securityonfig_test.go +++ b/config/security/securityonfig_test.go @@ -53,6 +53,7 @@ getEnv=["a", "b"] c.Assert(pc.Exec.OsEnv.Accept("e"), qt.IsFalse) c.Assert(pc.Funcs.Getenv.Accept("a"), qt.IsTrue) c.Assert(pc.Funcs.Getenv.Accept("c"), qt.IsFalse) + }) c.Run("String whitelist", func(c *qt.C) { @@ -79,6 +80,7 @@ osEnv="b" c.Assert(pc.Exec.Allow.Accept("d"), qt.IsFalse) c.Assert(pc.Exec.OsEnv.Accept("b"), qt.IsTrue) c.Assert(pc.Exec.OsEnv.Accept("e"), qt.IsFalse) + }) c.Run("Default exec.osEnv", func(c *qt.C) { @@ -103,6 +105,7 @@ allow="a" c.Assert(pc.Exec.Allow.Accept("a"), qt.IsTrue) c.Assert(pc.Exec.OsEnv.Accept("PATH"), qt.IsTrue) c.Assert(pc.Exec.OsEnv.Accept("e"), qt.IsFalse) + }) c.Run("Enable inline shortcodes, legacy", func(c *qt.C) { @@ -126,7 +129,9 @@ osEnv="b" pc, err := DecodeConfig(cfg) c.Assert(err, qt.IsNil) c.Assert(pc.EnableInlineShortcodes, qt.IsTrue) + }) + } func TestToTOML(t *testing.T) { @@ -135,7 +140,7 @@ func TestToTOML(t *testing.T) { got := DefaultConfig.ToTOML() c.Assert(got, qt.Equals, - "[security]\n enableInlineShortcodes = false\n [security.exec]\n allow = ['^dart-sass-embedded$', '^go$', '^npx$', '^postcss$']\n osEnv = ['(?i)^(PATH|PATHEXT|APPDATA|HOME|TMP|TEMP|TERM)$']\n\n [security.funcs]\n getenv = ['^HUGO_']\n\n [security.http]\n methods = ['(?i)GET|POST']\n urls = ['.*']", + "[security]\n enableInlineShortcodes = false\n [security.exec]\n allow = ['^dart-sass-embedded$', '^go$', '^npx$', '^postcss$']\n osEnv = ['(?i)^(PATH|PATHEXT|APPDATA|TMP|TEMP|TERM)$']\n\n [security.funcs]\n getenv = ['^HUGO_']\n\n [security.http]\n methods = ['(?i)GET|POST']\n urls = ['.*']", ) } |