diff options
| author | Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> | 2015-12-02 11:42:53 +0100 |
|---|---|---|
| committer | Anthony Fok <foka@debian.org> | 2015-12-02 07:07:05 -0700 |
| commit | 3f0f7eed68f44486c1e053bbce25c46c1d52a12f (patch) | |
| tree | 4bafd37bcd2ede6fb1c7f5838679a345dae83668 /commands/genman.go | |
| parent | 6959b7fa80f22aead6fa8c9b8ff3c4b8cc222a30 (diff) | |
Improve error handling in commands
Cobra, the CLI commander in use in Hugo, has some long awaited improvements in the error handling department.
This enables a more centralized error handling approach.
This commit introduces that by changing all the command funcs to `RunE`:
* The core part of the error logging, usage logging and `os.Exit(-1)` is now performed in one place and that one place only.
* The usage text is now only shown on invalid arguments etc. (user errors)
Fixes #1502
Diffstat (limited to 'commands/genman.go')
| -rw-r--r-- | commands/genman.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/commands/genman.go b/commands/genman.go index 68a98a46d..a842b49b8 100644 --- a/commands/genman.go +++ b/commands/genman.go @@ -18,7 +18,7 @@ var genmanCmd = &cobra.Command{ command-line interface. By default, it creates the man page files in the "man" directory under the current directory.`, - Run: func(cmd *cobra.Command, args []string) { + RunE: func(cmd *cobra.Command, args []string) error { header := &cobra.GenManHeader{ Section: "1", Manual: "Hugo Manual", @@ -37,6 +37,8 @@ in the "man" directory under the current directory.`, cmd.Root().GenManTree(header, genmandir) jww.FEEDBACK.Println("Done.") + + return nil }, } |