diff options
author | Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> | 2015-12-02 11:42:53 +0100 |
---|---|---|
committer | Anthony Fok <foka@debian.org> | 2015-12-02 07:07:05 -0700 |
commit | 3f0f7eed68f44486c1e053bbce25c46c1d52a12f (patch) | |
tree | 4bafd37bcd2ede6fb1c7f5838679a345dae83668 /commands/check.go | |
parent | 6959b7fa80f22aead6fa8c9b8ff3c4b8cc222a30 (diff) |
Improve error handling in commands
Cobra, the CLI commander in use in Hugo, has some long awaited improvements in the error handling department.
This enables a more centralized error handling approach.
This commit introduces that by changing all the command funcs to `RunE`:
* The core part of the error logging, usage logging and `os.Exit(-1)` is now performed in one place and that one place only.
* The usage text is now only shown on invalid arguments etc. (user errors)
Fixes #1502
Diffstat (limited to 'commands/check.go')
-rw-r--r-- | commands/check.go | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/commands/check.go b/commands/check.go index 0c8b3ba79..f17602246 100644 --- a/commands/check.go +++ b/commands/check.go @@ -23,9 +23,13 @@ var check = &cobra.Command{ Short: "Check content in the source directory", Long: `Hugo will perform some basic analysis on the content provided and will give feedback.`, - Run: func(cmd *cobra.Command, args []string) { - InitializeConfig() + RunE: func(cmd *cobra.Command, args []string) error { + if err := InitializeConfig(); err != nil { + return err + } site := hugolib.Site{} - site.Analyze() + + return site.Analyze() + }, } |