summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Tang <tangd@google.com>2019-12-10 12:37:52 -0800
committerBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>2019-12-10 23:48:44 +0100
commitc5f2f5837fdf6a30c7b28e8368033623b74a30a0 (patch)
treec2b79db1d9c7450ee2b2f697f6bfd1aa74cd67a9
parent0efb00c2a86ec3f52000a643f26f54bb2a9dfbd6 (diff)
markup: Add typographic chars from goldmark to toc
Fixes #6592
-rw-r--r--markup/goldmark/toc.go5
-rw-r--r--markup/goldmark/toc_test.go4
2 files changed, 4 insertions, 5 deletions
diff --git a/markup/goldmark/toc.go b/markup/goldmark/toc.go
index 897f0098b..1753ede1b 100644
--- a/markup/goldmark/toc.go
+++ b/markup/goldmark/toc.go
@@ -79,9 +79,8 @@ func (t *tocTransformer) Transform(n *ast.Document, reader text.Reader, pc parse
if found {
header.ID = string(id.([]byte))
}
- case ast.KindText:
- textNode := n.(*ast.Text)
- headingText.Write(textNode.Text(reader.Source()))
+ case ast.KindText, ast.KindString:
+ headingText.Write(n.Text(reader.Source()))
}
return s, nil
diff --git a/markup/goldmark/toc_test.go b/markup/goldmark/toc_test.go
index f2e15f593..d3a1613cf 100644
--- a/markup/goldmark/toc_test.go
+++ b/markup/goldmark/toc_test.go
@@ -32,7 +32,7 @@ func TestToc(t *testing.T) {
content := `
# Header 1
-## First h2
+## First h2---now with typography!
Some text.
@@ -61,7 +61,7 @@ And then some.
got := b.(converter.TableOfContentsProvider).TableOfContents().ToHTML(2, 3)
c.Assert(got, qt.Equals, `<nav id="TableOfContents">
<ul>
- <li><a href="#first-h2">First h2</a>
+ <li><a href="#first-h2---now-with-typography">First h2&mdash;now with typography!</a>
<ul>
<li><a href="#h3">H3</a></li>
</ul>