From 9dea20e06847f930920406e6de539db32e2644e0 Mon Sep 17 00:00:00 2001 From: Explorer09 Date: Wed, 4 May 2016 13:39:26 +0800 Subject: Rename Meter.setValues() functions to updateValues() Rationale (copied from htop issue #471): The function name "setValues" is misleading. For most OOP (object- oriented programming) contexts, setXXX functions mean they will change some member variables of an object into something specified in function arguments. But in the *Meter_setValues() case, the new values are not from the arguments, but from a hard-coded source. The caller is not supposed to change the values[] to anything it likes, but rather to "update" the values from the source. Hence, updateValues is a better name for this family of functions. --- HostnameMeter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'HostnameMeter.c') diff --git a/HostnameMeter.c b/HostnameMeter.c index ccfaaca9..4c3b051e 100644 --- a/HostnameMeter.c +++ b/HostnameMeter.c @@ -19,7 +19,7 @@ int HostnameMeter_attributes[] = { HOSTNAME }; -static void HostnameMeter_setValues(Meter* this, char* buffer, int size) { +static void HostnameMeter_updateValues(Meter* this, char* buffer, int size) { (void) this; gethostname(buffer, size-1); } @@ -29,7 +29,7 @@ MeterClass HostnameMeter_class = { .extends = Class(Meter), .delete = Meter_delete }, - .setValues = HostnameMeter_setValues, + .updateValues = HostnameMeter_updateValues, .defaultMode = TEXT_METERMODE, .maxItems = 0, .total = 100.0, -- cgit v1.2.3