summaryrefslogtreecommitdiffstats
path: root/OpenFilesScreen.c
AgeCommit message (Collapse)Author
2021-01-11Make Infoscreens the correct heightDaniel Lange
2020-11-24Improving Command display/sortNarendran Gopalakrishnan
2020-11-02Embracing branchesBenny Baumann
2020-11-02Spacing around operatorsBenny Baumann
2020-10-18Make all required includes explicitBenny Baumann
Information as seen by IWYU 0.12 + clang 9 on Linux
2020-10-16Rename StringUtils.[ch] to XUtils.[ch]Benny Baumann
2020-10-10OpenFilesScreen updateChristian Göttsche
- Remove local types and function from header file - Reduce OpenFiles_Data to neccessary size - Print file access mode (r/w/u) - Fix memory leak on consecutive items without an intermediate file item: ==15257==ERROR: LeakSanitizer: detected memory leaks Direct leak of 120 byte(s) in 12 object(s) allocated from: #0 0x48c864 in strdup (htop/htop+0x48c864) #1 0x542f68 in xStrdup htop/XAlloc.c:71:17 #2 0x50e225 in OpenFilesScreen_getProcessData htop/OpenFilesScreen.c:112:25 #3 0x50cd17 in OpenFilesScreen_scan htop/OpenFilesScreen.c:141:35 #4 0x4fd3eb in InfoScreen_run htop/InfoScreen.c:81:35 #5 0x4d58bb in actionLsof htop/Action.c:361:4 #6 0x501766 in MainPanel_eventHandler htop/MainPanel.c:80:19 #7 0x5289fa in ScreenManager_run htop/ScreenManager.c:227:19 #8 0x4f748e in main htop/htop.c:300:4 #9 0x7ff73e0d8cc9 in __libc_start_main csu/../csu/libc-start.c:308:16 SUMMARY: AddressSanitizer: 120 byte(s) leaked in 12 allocation(s).
2020-10-07Mark Object instances constChristian Göttsche
2020-10-05Update License consistently to GPLv2 as per COPYING fileDaniel Lange
2020-09-17Check for fdopen failure in OpenFilesScreen_getProcessDataChristian Göttsche
2020-09-17Properly close pipe handles when work is doneBenny Baumann
2020-09-17Barely ever seen any 1000 digit PIDs …Benny Baumann
2020-09-03Axe automated header generation.Zev Weiss
Reasoning: - implementation was unsound -- broke down when I added a fairly basic macro definition expanding to a struct initializer in a *.c file. - made it way too easy (e.g. via otherwise totally innocuous git commands) to end up with timestamps such that it always ran MakeHeader.py but never used its output, leading to overbuild noise when running what should be a null 'make'. - but mostly: it's just an awkward way of dealing with C code.
2019-06-23Close pipe after lsofJesin
2018-03-16Use fork/exec instead of popen to run lsof (#757)wangqr
Fixes #675
2018-02-18Replace size_t with int/void* unionHisham Muhammad
I was occasionally passing negative values to size_t. Plus, this better reflects the intent of the variant argument. Reported by Coverity: https://scan8.coverity.com/reports.htm#v13253/p10402/fileInstanceId=22093891&defectInstanceId=7543346&mergedDefectId=174179&fileStart=251&fileEnd=500
2017-07-27Security review: check results of snprintf.Hisham Muhammad
Calls marked with xSnprintf shouldn't fail. Abort program cleanly if any of them does.
2016-10-01Interpret TTY_NR column on Linux,Hisham
translate dev_t to major:minor on other platforms. Closes #316.
2016-06-19Dynamically adjust the size of line readsHisham Muhammad
* Dynamically adjust the size of line reads. * Remove some more uses of fgets with arbitrary sizes. * Fix reading of lines and width of n column. Fixes #514.
2016-02-02Check for failure in allocations.Hisham
2016-01-12refactor *Screen classes, add InfoScreen superclassHisham Muhammad
2015-09-16Clean up some needless malloc casts, convert some mallocs to callocs, and ↵Michael McConville
fix some style
2015-08-19Rename String to StringUtils.David Hunt
Fixes building on case-insensitive filesystems where String.h gets confused with <string.h>. From d734dacea0a10d0465dad4e95b3421511e7da112 Mon Sep 17 00:00:00 2001 From: David Hunt <dhunt@iolanthe.attlocal.net> Date: Sat, 11 Jul 2015 20:56:31 -0500 Subject: [PATCH 1/8] Rename String to StringUtils
2015-03-23incremental search and filter reintegrated!Hisham Muhammad
2015-03-23Move FunctionBar inside PanelHisham Muhammad
2014-04-24Let's see if this assert makes static analyzers happier.Hisham Muhammad
2014-04-22Fix display of open files.Hisham Muhammad
Cleanup the code to prevent this bug from happening again.
2014-02-27alignment improvementsHisham Muhammad
2014-01-16Fix order of calloc arguments.Hisham Muhammad
(Patch by Dawid Gajownik)
2012-12-05Changes in object model: separate class objects to store vtable. Also, nicer ↵Hisham Muhammad
UTF-8 display of big numbers.
2012-11-10search and filter for the strace and lsof screens!Hisham Muhammad
2011-12-26major header cleanupHisham Muhammad
2011-12-25Use strdup explicitlyHisham Muhammad
2011-11-18Mega-commit with features and tweaks for 1.0:Hisham Muhammad
* Performance improvements * Support for splitting CPU meters into two or four columns (thanks to Wim Heirman) * Switch from PLPA, which is now deprecated, to HWLOC. * Bring back support for native Linux sched_setaffinity, so we don't have to use HWLOC where we don't need to. * Support for typing in user names and column fields in selection panels.
2011-03-22launch lsof for parent process when called on threads.Hisham Muhammad
2010-09-02don't resolve port namesHisham Muhammad
2010-08-24add support for steal/guest CPU time measurementHisham Muhammad
simplify processor data accounting (add CPUData structure) remove Process_clone trick
2010-03-03fix memory leakHisham Muhammad
2010-02-25warning fixesHisham Muhammad
2009-10-16extra checks for lsof failuresHisham Muhammad
2009-06-08fix to minor bug affecting the build process, a maintenance release will ↵Hisham Muhammad
follow shortly.
2009-06-02oops, add missing filesHisham Muhammad