diff options
author | Christian Göttsche <cgzones@googlemail.com> | 2020-09-24 12:01:59 +0200 |
---|---|---|
committer | cgzones <cgzones@googlemail.com> | 2020-09-24 18:06:59 +0200 |
commit | 52338171220af1ff009ea30114a290c80847b2dd (patch) | |
tree | 4cffe412ee16e7cc1231878aca4f78e81030ca10 /Action.c | |
parent | 7ecea3d485a8e39ede377b4e74e5fee5bbfb4edd (diff) |
Avoid unsigned integer overflow
unsigned integer overflows are well-defined, but they might point to a counting issue.
Having the code free of unsigned overflows makes it easier to spot potential bugs.
Action.c:332:27: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'uid_t' (aka 'unsigned int') changed the value to 4294967295 (32-bit, unsigned)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Action.c:332:27 in
Diffstat (limited to 'Action.c')
-rw-r--r-- | Action.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -329,7 +329,7 @@ static Htop_Reaction actionFilterByUser(State* st) { ListItem* picked = (ListItem*) Action_pickFromVector(st, usersPanel, 20, false); if (picked) { if (picked == allUsers) { - st->pl->userId = -1; + st->pl->userId = (uid_t)-1; } else { Action_setUserOnly(ListItem_getRef(picked), &(st->pl->userId)); } |