summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSean E. Russell <ser@ser1.net>2020-05-01 08:27:03 -0500
committerSean E. Russell <ser@ser1.net>2020-05-01 08:27:03 -0500
commit4563131b2a34993835e06c66756c46d5c7f06625 (patch)
tree9a47aa79c9c121e4f91b4e6218f777840febdc94
parent9a81d116f42a4f92d68944e13ffc37a0ef6ecf71 (diff)
Update todos
-rw-r--r--cmd/gotop/main.go10
-rw-r--r--devices/cpu.go2
-rw-r--r--devices/devices.go2
-rw-r--r--devices/temp_openbsd.go2
-rw-r--r--widgets/batterygauge.go1
-rw-r--r--widgets/disk.go2
6 files changed, 4 insertions, 15 deletions
diff --git a/cmd/gotop/main.go b/cmd/gotop/main.go
index 25dd5b8..23ed512 100644
--- a/cmd/gotop/main.go
+++ b/cmd/gotop/main.go
@@ -334,17 +334,7 @@ func eventLoop(c gotop.Config, grid *layout.MyGrid) {
}
}
-// TODO: @devices fans
-// TODO: @devices mpd visualizer
-// TODO: @devices color bars for memory, a-la bashtop
-// TODO: Add tab completion for Linux https://gist.github.com/icholy/5314423
// TODO: state:merge #135 linux console font (cmatsuoka/console-font)
-// TODO: Abstract out the UI toolkit. mum4k/termdash, VladimirMarkelov/clui, gcla/gowid, rivo/tview, marcusolsson/tui-go might work better for some OS/Archs. Performance/memory use comparison would be interesting.
-// TODO: more unit tests, benchmarks
-// TODO: README is getting long. Move to wiki.
-// TODO: add verbose debugging option
-// TODO: find VMs for FreeBSD, etc for testing gotop
-// TODO: add README about extensions, and wiki page for writing extensions
func main() {
// For performance testing
//go func() {
diff --git a/devices/cpu.go b/devices/cpu.go
index 1d8d23d..436ccb1 100644
--- a/devices/cpu.go
+++ b/devices/cpu.go
@@ -1,7 +1,5 @@
package devices
-// TODO: https://github.com/elastic/go-sysinfo
-
import (
"log"
"time"
diff --git a/devices/devices.go b/devices/devices.go
index c3cad42..7360578 100644
--- a/devices/devices.go
+++ b/devices/devices.go
@@ -8,6 +8,8 @@ const (
Temperatures = "Temperatures" // Device domain for temperature sensors
)
+// TODO: Redesign; this is not thread safe, and it's easy to write code that triggers concurrent modification panics. Channels?
+
var Domains []string = []string{Temperatures}
var _shutdownFuncs []func() error
var _devs map[string][]string
diff --git a/devices/temp_openbsd.go b/devices/temp_openbsd.go
index d889d78..195882a 100644
--- a/devices/temp_openbsd.go
+++ b/devices/temp_openbsd.go
@@ -15,7 +15,7 @@ import (
"unsafe"
)
-// TODO: Add filtering. Getting the temperature sensor names is non-trivial for OpenBSD, and until I can test it, leave it unimplemented
+// TODO: Add sensor filtering
func init() {
RegisterTemp(update)
}
diff --git a/widgets/batterygauge.go b/widgets/batterygauge.go
index 45fec1c..968a63c 100644
--- a/widgets/batterygauge.go
+++ b/widgets/batterygauge.go
@@ -57,6 +57,7 @@ func (b *BatteryGauge) EnableMetric() {
}
func (b *BatteryGauge) update() {
+ // FIXME: Getting a lot of these in the logs
bats, err := battery.GetAll()
if err != nil {
log.Printf("error setting up batteries: %v", err)
diff --git a/widgets/disk.go b/widgets/disk.go
index fb77ace..0c86dc9 100644
--- a/widgets/disk.go
+++ b/widgets/disk.go
@@ -32,8 +32,6 @@ type DiskWidget struct {
metric map[string]prometheus.Gauge
}
-// TODO: Add filtering
-// TODO: Abstract out device from widget
func NewDiskWidget() *DiskWidget {
self := &DiskWidget{
Table: ui.NewTable(),