Report failure to copy to clipboard (#1410)

* (refactor) move copy_commit_hash from revlog into commitlist, and make fewer functions public in commitlist
* (refactor) reduce duplication in commit copying code; use already-stored commits instead of looking up items
* (clipboard) actually check subprocess exit status, and report failure instead of ignoring it
* (commitlist) display popup with copy failure instead of exiting the application on error

1 files changed, 13 insertions, 3 deletions

diff --git a/src/clipboard.rs b/src/clipboard.rs
index fcb6af12..61170fe2 100644
--- a/src/clipboard.rs
+++ b/src/clipboard.rs
@@ -17,6 +17,7 @@ fn exec_copy_with_args(
 		.args(args)
 		.stdin(Stdio::piped())
 		.stdout(Stdio::null())
+		.stderr(Stdio::piped())
 		.spawn()
 		.map_err(|e| anyhow!("`{:?}`: {}", command, e))?;
 
@@ -27,11 +28,20 @@ fn exec_copy_with_args(
 		.write_all(text.as_bytes())
 		.map_err(|e| anyhow!("`{:?}`: {}", command, e))?;
 
-	process
-		.wait()
+	let out = process
+		.wait_with_output()
 		.map_err(|e| anyhow!("`{:?}`: {}", command, e))?;
 
-	Ok(())
+	if out.status.success() {
+		Ok(())
+	} else {
+		let msg = if out.stderr.is_empty() {
+			format!("{}", out.status).into()
+		} else {
+			String::from_utf8_lossy(&out.stderr)
+		};
+		Err(anyhow!("`{command:?}`: {msg}"))
+	}
 }
 
 fn exec_copy(command: &str, text: &str) -> Result<()> {