summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Goodman <wagoodman@gmail.com>2019-10-07 18:28:44 -0400
committerAlex Goodman <wagoodman@gmail.com>2019-10-07 18:34:11 -0400
commitfd3459eb02b9c1cb59f674c22e42354f37b6f504 (patch)
tree3290d2fec4ba8279b97e051875241ec846819cee
parentfcb5ec01ef27e6882058c4c04cfc93a77c194c8d (diff)
fix validation errors
-rw-r--r--cmd/root.go2
-rw-r--r--dive/image/podman/resolver.go3
2 files changed, 4 insertions, 1 deletions
diff --git a/cmd/root.go b/cmd/root.go
index 41abe52..877bca7 100644
--- a/cmd/root.go
+++ b/cmd/root.go
@@ -57,7 +57,7 @@ func initCli() {
for _, key := range []string{"lowestEfficiency", "highestWastedBytes", "highestUserWastedPercent"} {
if err := ciConfig.BindPFlag(fmt.Sprintf("rules.%s", key), rootCmd.Flags().Lookup(key)); err != nil {
- log.Fatal("Unable to bind '%s' flag:", key, err)
+ log.Fatalf("Unable to bind '%s' flag: %v", key, err)
}
}
diff --git a/dive/image/podman/resolver.go b/dive/image/podman/resolver.go
index 37f5253..83e8a12 100644
--- a/dive/image/podman/resolver.go
+++ b/dive/image/podman/resolver.go
@@ -84,6 +84,9 @@ func (r *resolver) resolveFromDockerArchive(id string) (*image.Image, error) {
defer os.Remove(path)
file, err := os.Open(path)
+ if err != nil {
+ return nil, err
+ }
defer file.Close()
img, err := docker.NewImageArchive(ioutil.NopCloser(bufio.NewReader(file)))