summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSylvestre Ledru <sylvestre@debian.org>2024-07-26 00:45:04 +0200
committerGitHub <noreply@github.com>2024-07-26 00:45:04 +0200
commiteaba6bf9776145b880841e6a96c196d928319004 (patch)
tree3791e15001e4b7da31cb8366b93989cba0094e37
parent79d7158aac37a03d7e454de3154f3c504149a428 (diff)
parent587efd1d4b59cf989da5625a2908857c6e24fc5c (diff)
Merge pull request #6592 from cakebaker/clippy_fix_warnings
clippy: fix warnings introduced by Rust 1.80
-rw-r--r--src/uu/cp/src/cp.rs3
-rw-r--r--src/uu/csplit/src/csplit.rs2
-rw-r--r--src/uu/csplit/src/split_name.rs2
-rw-r--r--src/uu/realpath/src/realpath.rs10
-rw-r--r--src/uucore/src/lib/features/mode.rs13
-rw-r--r--src/uucore/src/lib/mods/error.rs2
6 files changed, 15 insertions, 17 deletions
diff --git a/src/uu/cp/src/cp.rs b/src/uu/cp/src/cp.rs
index 3b02c2c58..33c16a0fa 100644
--- a/src/uu/cp/src/cp.rs
+++ b/src/uu/cp/src/cp.rs
@@ -1947,7 +1947,8 @@ fn handle_copy_mode(
///
/// * `Ok(Permissions)` - The calculated permissions for the destination file.
/// * `Err(CopyError)` - An error occurred while getting the metadata of the destination file.
-/// Allow unused variables for Windows (on options)
+///
+// Allow unused variables for Windows (on options)
#[allow(unused_variables)]
fn calculate_dest_permissions(
dest: &Path,
diff --git a/src/uu/csplit/src/csplit.rs b/src/uu/csplit/src/csplit.rs
index 7d625d925..9e132b704 100644
--- a/src/uu/csplit/src/csplit.rs
+++ b/src/uu/csplit/src/csplit.rs
@@ -351,7 +351,7 @@ impl<'a> SplitWriter<'a> {
/// In addition to errors reading/writing from/to a file, the following errors may be returned:
/// - if no line matched, an [`CsplitError::MatchNotFound`].
/// - if there are not enough lines to accommodate the offset, an
- /// [`CsplitError::LineOutOfRange`].
+ /// [`CsplitError::LineOutOfRange`].
#[allow(clippy::cognitive_complexity)]
fn do_to_match<I>(
&mut self,
diff --git a/src/uu/csplit/src/split_name.rs b/src/uu/csplit/src/split_name.rs
index e2432f3ce..29b626efd 100644
--- a/src/uu/csplit/src/split_name.rs
+++ b/src/uu/csplit/src/split_name.rs
@@ -19,7 +19,7 @@ impl SplitName {
/// Creates a new SplitName with the given user-defined options:
/// - `prefix_opt` specifies a prefix for all splits.
/// - `format_opt` specifies a custom format for the suffix part of the filename, using the
- /// `sprintf` format notation.
+ /// `sprintf` format notation.
/// - `n_digits_opt` defines the width of the split number.
///
/// # Caveats
diff --git a/src/uu/realpath/src/realpath.rs b/src/uu/realpath/src/realpath.rs
index b099a5f37..834d9d083 100644
--- a/src/uu/realpath/src/realpath.rs
+++ b/src/uu/realpath/src/realpath.rs
@@ -266,11 +266,11 @@ fn resolve_path(
/// Conditionally converts an absolute path to a relative form,
/// according to the rules:
/// 1. if only `relative_to` is given, the result is relative to `relative_to`
-/// 1. if only `relative_base` is given, it checks whether given `path` is a descendant
-/// of `relative_base`, on success the result is relative to `relative_base`, otherwise
-/// the result is the given `path`
-/// 1. if both `relative_to` and `relative_base` are given, the result is relative to `relative_to`
-/// if `path` is a descendant of `relative_base`, otherwise the result is `path`
+/// 2. if only `relative_base` is given, it checks whether given `path` is a descendant
+/// of `relative_base`, on success the result is relative to `relative_base`, otherwise
+/// the result is the given `path`
+/// 3. if both `relative_to` and `relative_base` are given, the result is relative to `relative_to`
+/// if `path` is a descendant of `relative_base`, otherwise the result is `path`
///
/// For more information see
/// <https://www.gnu.org/software/coreutils/manual/html_node/Realpath-usage-examples.html>
diff --git a/src/uucore/src/lib/features/mode.rs b/src/uucore/src/lib/features/mode.rs
index c2da380bf..9a7336b34 100644
--- a/src/uucore/src/lib/features/mode.rs
+++ b/src/uucore/src/lib/features/mode.rs
@@ -191,14 +191,11 @@ pub fn strip_minus_from_mode(args: &mut Vec<String>) -> bool {
break;
}
if let Some(arg_stripped) = arg.strip_prefix('-') {
- if let Some(second) = arg.chars().nth(1) {
- match second {
- 'r' | 'w' | 'x' | 'X' | 's' | 't' | 'u' | 'g' | 'o' | '0'..='7' => {
- *arg = arg_stripped.to_string();
- return true;
- }
- _ => {}
- }
+ if let Some('r' | 'w' | 'x' | 'X' | 's' | 't' | 'u' | 'g' | 'o' | '0'..='7') =
+ arg.chars().nth(1)
+ {
+ *arg = arg_stripped.to_string();
+ return true;
}
}
}
diff --git a/src/uucore/src/lib/mods/error.rs b/src/uucore/src/lib/mods/error.rs
index 571ed12e2..3a8af3e7f 100644
--- a/src/uucore/src/lib/mods/error.rs
+++ b/src/uucore/src/lib/mods/error.rs
@@ -29,7 +29,7 @@
//! * When `Ok` is returned, the code set with [`set_exit_code`] is used as exit code. If
//! [`set_exit_code`] was not used, then `0` is used.
//! * When `Err` is returned, the code corresponding with the error is used as exit code and the
-//! error message is displayed.
+//! error message is displayed.
//!
//! Additionally, the errors can be displayed manually with the [`crate::show`] and [`crate::show_if_err`] macros:
//! ```ignore