From 292d4743f21a3db2697d2537d871db9b58dde875 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 17 Apr 2021 11:23:39 +0200 Subject: Make ConfigBuilder::set_{default,overwrite} take AsRef To be a bit more flexible here on the user side of the API, make the API take AsRef, which gives the user the ability to pass `String` to the API if they want to. Signed-off-by: Matthias Beyer --- src/builder.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/builder.rs b/src/builder.rs index 23090c6..8abbe54 100644 --- a/src/builder.rs +++ b/src/builder.rs @@ -77,11 +77,12 @@ impl ConfigBuilder { /// # Errors /// /// Fails if `Expression::from_str(key)` fails. - pub fn set_default(&mut self, key: &str, value: T) -> error::Result<&mut ConfigBuilder> + pub fn set_default(&mut self, key: S, value: T) -> error::Result<&mut ConfigBuilder> where + S: AsRef, T: Into, { - self.defaults.insert(Expression::from_str(key)?, value.into()); + self.defaults.insert(Expression::from_str(key.as_ref())?, value.into()); Ok(self) } @@ -103,11 +104,12 @@ impl ConfigBuilder { /// # Errors /// /// Fails if `Expression::from_str(key)` fails. - pub fn set_override(&mut self, key: &str, value: T) -> error::Result<&mut ConfigBuilder> + pub fn set_override(&mut self, key: S, value: T) -> error::Result<&mut ConfigBuilder> where + S: AsRef, T: Into, { - self.overrides.insert(Expression::from_str(key)?, value.into()); + self.overrides.insert(Expression::from_str(key.as_ref())?, value.into()); Ok(self) } -- cgit v1.2.3