Merge #200

200: Update MSRV: 1.62 -> 1.67 r=matthiasbeyer a=matthiasbeyer



Co-authored-by: Matthias Beyer <mail@beyermatthias.de>

19 files changed, 80 insertions, 83 deletions

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 09e7a06..5a2274a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         rust:
-          - 1.62.0
+          - 1.67.0
           - stable
           - beta
           # - nightly
@@ -63,7 +63,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.62.0
+          toolchain: 1.67.0
       - run: rustup component add rustfmt
       - name: cargo-fmt
         uses: actions-rs/cargo@v1
@@ -78,7 +78,7 @@ jobs:
     strategy:
       matrix:
         rust:
-          - 1.62.0
+          - 1.67.0
           - stable
           - beta
           # - nightly
@@ -105,7 +105,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.62.0
+          toolchain: 1.67.0
           override: true
       - uses: swatinem/rust-cache@v2
       - run: rustup component add clippy
diff --git a/flake.nix b/flake.nix
index 041d11a..42978a6 100644
--- a/flake.nix
+++ b/flake.nix
@@ -73,6 +73,9 @@
         devShells.changelog = pkgs.mkShell {
           nativeBuildInputs = [
             rustTarget
+
+            pkgs.openssl
+            pkgs.pkg-config
           ];
         };
       }
diff --git a/rust-toolchain b/rust-toolchain
index 76d0536..65ee095 100644
--- a/rust-toolchain
+++ b/rust-toolchain
@@ -1 +1 @@
-1.62.0
+1.67.0
diff --git a/src/cli.rs b/src/cli.rs
index a664bcf..e33869c 100644
--- a/src/cli.rs
+++ b/src/cli.rs
@@ -114,7 +114,7 @@ pub struct KV {
 
 fn kv_value_parser(s: &str) -> Result<KV, String> {
     if s.chars().filter(|c| *c == '=').count() != 1 {
-        Err(format!("Cannot parse as key-value: '{}'", s))
+        Err(format!("Cannot parse as key-value: '{s}'"))
     } else {
         let (key, value) = s.split_once('=').unwrap(); // safe because above check
         Ok(KV {
diff --git a/src/command/new_command.rs b/src/command/new_command.rs
index 9981aa1..8c8192e 100644
--- a/src/command/new_command.rs
+++ b/src/command/new_command.rs
@@ -287,7 +287,7 @@ fn interactive_provide(
     match desc.fragment_type() {
         FragmentDataType::Ty(FragmentDataTypeDefinite::Bool) => {
             let mut dialoguer = Confirm::new();
-            dialoguer.with_prompt(format!("'{}'?", key));
+            dialoguer.with_prompt(format!("'{key}'?"));
             if let Some(data) = desc.default_value() {
                 if let FragmentData::Bool(b) = data {
                     dialoguer.default(*b);
@@ -313,7 +313,7 @@ fn interactive_provide(
         }
         FragmentDataType::Ty(FragmentDataTypeDefinite::Int) => {
             let mut dialoguer = Input::<u64>::new();
-            dialoguer.with_prompt(format!("Enter a number for '{}'", key));
+            dialoguer.with_prompt(format!("Enter a number for '{key}'"));
 
             if let Some(data) = desc.default_value() {
                 if let FragmentData::Int(i) = data {
@@ -331,7 +331,7 @@ fn interactive_provide(
         }
         FragmentDataType::Ty(FragmentDataTypeDefinite::Str) => {
             let mut dialoguer = Input::<String>::new();
-            dialoguer.with_prompt(format!("Enter a text for '{}'", key));
+            dialoguer.with_prompt(format!("Enter a text for '{key}'"));
 
             if let Some(data) = desc.default_value() {
                 if let FragmentData::Str(s) = data {
diff --git a/src/command/release_command.rs b/src/command/release_command.rs
index 933d490..436e25d 100644
--- a/src/command/release_command.rs
+++ b/src/command/release_command.rs
@@ -49,7 +49,7 @@ impl crate::command::Command for ReleaseCommand {
             .write(true)
             .open(changelog_file_path)?;
 
-        write!(changelog_file, "{}", changelog_contents)?;
+        write!(changelog_file, "{changelog_contents}")?;
         changelog_file.sync_all()?;
         Ok(())
     }
@@ -210,8 +210,7 @@ mod tests {
 
         assert!(
             predicates::str::contains("CHANGELOG").eval(&template),
-            "Does not contain 'CHANGELOG': {}",
-            template
+            "Does not contain 'CHANGELOG': {template}"
         );
     }
 
@@ -240,14 +239,12 @@ mod tests {
 
         assert!(
             predicates::str::contains("## v0.1.0").eval(&template),
-            "Does not contain '## v0.1.0': {}",
-            template
+            "Does not contain '## v0.1.0': {template}"
         );
 
         assert!(
             predicates::str::contains("test for 0.1.0").eval(&template),
-            "Does not contain 'test text': {}",
-            template
+            "Does not contain 'test text': {template}"
         );
     }
 
@@ -276,8 +273,7 @@ mod tests {
 
         assert!(
             predicates::str::contains("(#123)").eval(&template),
-            "Does not contain '(#123)': {}",
-            template
+            "Does not contain '(#123)': {template}"
         );
     }
 
@@ -323,13 +319,11 @@ mod tests {
 
         assert!(
             predicates::str::contains("## v0.1.0").eval(&template),
-            "Does not contain '## v0.1.0': {}",
-            template
+            "Does not contain '## v0.1.0': {template}"
         );
         assert!(
             predicates::str::contains("## v0.2.0").eval(&template),
-            "Does not contain '## v0.2.0': {}",
-            template
+            "Does not contain '## v0.2.0': {template}"
         );
 
         let line_number_of_010 = {
@@ -352,8 +346,7 @@ mod tests {
 
         assert!(
             line_number_of_020 < line_number_of_010,
-            "line with v0.1.0 should come _after_ line with v0.2.0: {}",
-            template
+            "line with v0.1.0 should come _after_ line with v0.2.0: {template}"
         );
     }
 }
diff --git a/src/error.rs b/src/error.rs
index 56721e1..0443c02 100644
--- a/src/error.rs
+++ b/src/error.rs
@@ -24,7 +24,7 @@ pub enum Error {
     Cargo(#[from] cargo_metadata::Error),
 
     #[error("Error in handlebars template")]
-    HandlebarsTemplate(#[from] handlebars::TemplateError),
+    HandlebarsTemplate(#[from] Box<handlebars::TemplateError>),
 
     #[error("Error during template rendering")]
     HandlebarsRender(#[from] handlebars::RenderError),
diff --git a/src/fragment.rs b/src/fragment.rs
index 020cbcc..fd925f5 100644
--- a/src/fragment.rs
+++ b/src/fragment.rs
@@ -80,9 +80,9 @@ impl Fragment {
             }
         };
 
-        writeln!(writer, "{}", seperator)?;
-        writeln!(writer, "{}", header)?;
-        writeln!(writer, "{}", seperator)?;
+        writeln!(writer, "{seperator}")?;
+        writeln!(writer, "{header}")?;
+        writeln!(writer, "{seperator}")?;
         writeln!(writer, "{}", self.text)?;
         Ok(())
     }
@@ -136,9 +136,9 @@ pub struct FragmentDataDisplay<'a>(&'a FragmentData);
 impl<'a> std::fmt::Display for FragmentDataDisplay<'a> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self.0 {
-            FragmentData::Bool(b) => write!(f, "{}", b),
-            FragmentData::Int(i) => write!(f, "{}", i),
-            FragmentData::Str(s) => write!(f, "{}", s),
+            FragmentData::Bool(b) => write!(f, "{b}"),
+            FragmentData::Int(i) => write!(f, "{i}"),
+            FragmentData::Str(s) => write!(f, "{s}"),
         }
     }
 }
@@ -185,10 +185,10 @@ impl FragmentDataType {
             FragmentDataType::OneOf(list) => {
                 let list = list
                     .iter()
-                    .map(|el| format!("'{}'", el))
+                    .map(|el| format!("'{el}'"))
                     .collect::<Vec<_>>()
                     .join(", ");
-                format!("one of: {}", list)
+                format!("one of: {list}")
             }
         }
     }
@@ -229,7 +229,7 @@ mod tests {
         );
 
         let f = Fragment::from_reader(&mut Cursor::new(s));
-        assert!(f.is_ok(), "Not ok: {:?}", f);
+        assert!(f.is_ok(), "Not ok: {f:?}");
         let f = f.unwrap();
         assert!(f.text().is_empty());
         assert!(f.header().is_empty());
@@ -245,7 +245,7 @@ mod tests {
         );
 
         let f = Fragment::from_reader(&mut Cursor::new(s));
-        assert!(f.is_ok(), "Not ok: {:?}", f);
+        assert!(f.is_ok(), "Not ok: {f:?}");
         let f = f.unwrap();
         assert_eq!(f.text(), "This is some text");
         assert!(f.header().is_empty());
@@ -261,7 +261,7 @@ mod tests {
         );
 
         let f = Fragment::from_reader(&mut Cursor::new(s));
-        assert!(f.is_ok(), "Not ok: {:?}", f);
+        assert!(f.is_ok(), "Not ok: {f:?}");
         let f = f.unwrap();
         assert!(f.text().is_empty(), "Not empty: '{}'", f.text());
         assert!(
@@ -277,7 +277,7 @@ mod tests {
 
         let foo = match f.header().get("foo").unwrap() {
             FragmentData::Str(s) => s,
-            other => panic!("Expected String, found: {:?}", other),
+            other => panic!("Expected String, found: {other:?}"),
         };
 
         assert_eq!(
@@ -298,7 +298,7 @@ mod tests {
         );
 
         let f = Fragment::from_reader(&mut Cursor::new(s));
-        assert!(f.is_ok(), "Not ok: {:?}", f);
+        assert!(f.is_ok(), "Not ok: {f:?}");
         let f = f.unwrap();
         assert!(f.text().is_empty(), "Not empty: '{}'", f.text());
         assert!(
@@ -314,7 +314,7 @@ mod tests {
 
         let foo = match f.header().get("foo").unwrap() {
             FragmentData::Str(s) => s,
-            other => panic!("Expected String, found: {:?}", other),
+            other => panic!("Expected String, found: {other:?}"),
         };
 
         assert_eq!(
diff --git a/src/template/group_by_helper.rs b/src/template/group_by_helper.rs
index 283bb58..05e35fc 100644
--- a/src/template/group_by_helper.rs
+++ b/src/template/group_by_helper.rs
@@ -51,14 +51,14 @@ impl HelperDef for GroupByHelper {
                     .into_iter()
                     .group_by(|elt: &serde_json::Value| {
                         elt.get("header")
-                            .and_then(|hdr| hdr.get(&group_by_attr))
+                            .and_then(|hdr| hdr.get(group_by_attr))
                             .cloned()
                     })
                     .into_iter()
                 {
                     let list = list.into_iter().collect();
                     let group = group.ok_or_else(|| {
-                        RenderError::new(format!("Failed to group by '{}', not all elements in the list have that attribute! List: {:?}", group_by_attr, list))
+                        RenderError::new(format!("Failed to group by '{group_by_attr}', not all elements in the list have that attribute! List: {list:?}"))
                     })?;
 
                     res.insert(group.to_string(), serde_json::Value::Array(list));
diff --git a/src/template/mod.rs b/src/template/mod.rs
index 9ac29d9..cc03b0f 100644
--- a/src/template/mod.rs
+++ b/src/template/mod.rs
@@ -10,7 +10,9 @@ mod sort_versions_helper;
 pub fn new_handlebars(template_source: &str) -> Result<Handlebars, Error> {
     let mut handlebars = Handlebars::new();
     handlebars.register_escape_fn(handlebars::no_escape);
-    handlebars.register_template_string(crate::consts::INTERNAL_TEMPLATE_NAME, template_source)?;
+    handlebars
+        .register_template_string(crate::consts::INTERNAL_TEMPLATE_NAME, template_source)
+        .map_err(Box::new)?;
     handlebars.register_helper(
         "sort_versions",
         Box::new(self::sort_versions_helper::sort_versions),
diff --git a/tests/common.rs b/tests/common.rs
index be9d3fd..efebe17 100644
--- a/tests/common.rs
+++ b/tests/common.rs
@@ -2,7 +2,7 @@
 
 pub fn init_git(temp_dir: &std::path::Path) {
     if !std::process::Command::new("git")
-        .args(&["init"])
+        .args(["init"])
         .current_dir(temp_dir)
         .status()
         .unwrap()
@@ -14,7 +14,7 @@ pub fn init_git(temp_dir: &std::path::Path) {
 
 pub fn init_cargo(temp_dir: &std::path::Path, name: &str) {
     if !std::process::Command::new("cargo")
-        .args(&["init", "--bin", "--name", name])
+        .args(["init", "--bin", "--name", name])
         .current_dir(temp_dir)
         .status()
         .unwrap()
@@ -27,8 +27,8 @@ pub fn init_cargo(temp_dir: &std::path::Path, name: &str) {
 pub fn init_cargo_changelog(temp_dir: &std::path::Path) {
     assert_cmd::Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["init"])
-        .current_dir(&temp_dir)
+        .args(["init"])
+        .current_dir(temp_dir)
         .assert()
         .success();
 }
diff --git a/tests/generate_command.rs b/tests/generate_command.rs
index e8f1608..6ebc936 100644
--- a/tests/generate_command.rs
+++ b/tests/generate_command.rs
@@ -19,7 +19,7 @@ fn generate_command_creates_new_directory() {
     // call `cargo-changelog generate`
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["generate", "minor"])
+        .args(["generate", "minor"])
         .current_dir(&temp_dir)
         .assert()
         .success();
@@ -38,7 +38,7 @@ fn generate_command_moves_from_unreleased_dir() {
     self::common::init_cargo_changelog(temp_dir.path());
 
     self::common::cargo_changelog_new(temp_dir.path())
-        .args(&[
+        .args([
             "--format=yaml",
             "--set",
             "issue=123",
@@ -77,7 +77,7 @@ fn generate_command_moves_from_unreleased_dir() {
     // call `cargo-changelog generate`
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["generate", "minor"])
+        .args(["generate", "minor"])
         .current_dir(&temp_dir)
         .assert()
         .success();
diff --git a/tests/new_command.rs b/tests/new_command.rs
index 3c32430..68de468 100644
--- a/tests/new_command.rs
+++ b/tests/new_command.rs
@@ -9,7 +9,7 @@ fn new_command_creates_yaml_file() {
     self::common::init_cargo_changelog(temp_dir.path());
 
     self::common::cargo_changelog_new(temp_dir.path())
-        .args(&[
+        .args([
             "--format=yaml",
             "--set",
             "issue=123",
@@ -108,12 +108,12 @@ fn new_command_with_text_creates_yaml_with_text_from_stdin() {
             .open(&path)
             .unwrap();
 
-        write!(file, "{}", test_text).unwrap();
+        write!(file, "{test_text}").unwrap();
         file.sync_all().unwrap();
         drop(file); // make sure we close the handle
 
         self::common::cargo_changelog_new(temp_dir.path())
-            .args(&[
+            .args([
                 "--format=yaml",
                 "--set",
                 "issue=123",
@@ -129,7 +129,7 @@ fn new_command_with_text_creates_yaml_with_text_from_stdin() {
             .success();
     }
 
-    let fragment_file = std::fs::read_dir(&temp_dir.path().join(".changelogs").join("unreleased"))
+    let fragment_file = std::fs::read_dir(temp_dir.path().join(".changelogs").join("unreleased"))
         .unwrap()
         .into_iter()
         .find(|rde| match rde {
@@ -168,12 +168,12 @@ fn new_command_with_text_creates_yaml_with_text_from_file() {
             .open(&path)
             .unwrap();
 
-        write!(file, "{}", test_text).unwrap();
+        write!(file, "{test_text}").unwrap();
         file.sync_all().unwrap();
         drop(file); // make sure we close the handle
 
         self::common::cargo_changelog_new(temp_dir.path())
-            .args(&[
+            .args([
                 "--format=yaml",
                 "--set",
                 "issue=123",
@@ -191,7 +191,7 @@ fn new_command_with_text_creates_yaml_with_text_from_file() {
             .success();
     }
 
-    let fragment_file = std::fs::read_dir(&temp_dir.path().join(".changelogs").join("unreleased"))
+    let fragment_file = std::fs::read_dir(temp_dir.path().join(".changelogs").join("unreleased"))
         .unwrap()
         .into_iter()
         .find(|rde| match rde {
@@ -220,7 +220,7 @@ fn new_command_creates_toml_header() {
     self::common::init_cargo_changelog(temp_dir.path());
 
     self::common::cargo_changelog_new(temp_dir.path())
-        .args(&[
+        .args([
             "--format=toml",
             "--set",
             "issue=123",
@@ -234,7 +234,7 @@ fn new_command_creates_toml_header() {
 
     let unreleased_dir = temp_dir.path().join(".changelogs").join("unreleased");
 
-    let new_fragment_file = std::fs::read_dir(&unreleased_dir)
+    let new_fragment_file = std::fs::read_dir(unreleased_dir)
         .unwrap()
         .into_iter()
         .find(|rde| match rde {
@@ -283,7 +283,7 @@ fn new_command_cannot_create_nonexistent_oneof() {
     }
 
     self::common::cargo_changelog_new(temp_dir.path())
-        .args(&[
+        .args([
             "--format=toml",
             "--set",
             "issue=123",
diff --git a/tests/new_command_creates_default_header.rs b/tests/new_command_creates_default_header.rs
index c083d66..632a37e 100644
--- a/tests/new_command_creates_default_header.rs
+++ b/tests/new_command_creates_default_header.rs
@@ -29,7 +29,7 @@ fn new_command_creates_default_header() {
     }
 
     self::common::cargo_changelog_new(temp_dir.path())
-        .args(&[
+        .args([
             "--format=yaml",
             "--set",
             "issue=123",
@@ -44,7 +44,7 @@ fn new_command_creates_default_header() {
         .success();
 
     let unreleased_dir = temp_dir.path().join(".changelogs").join("unreleased");
-    let fragment = std::fs::read_dir(&unreleased_dir)
+    let fragment = std::fs::read_dir(unreleased_dir)
         .unwrap()
         .into_iter()
         .find(|rde| match rde {
diff --git a/tests/new_command_editor.rs b/tests/new_command_editor.rs
index 0e749db..a126b75 100644
--- a/tests/new_command_editor.rs
+++ b/tests/new_command_editor.rs
@@ -32,7 +32,7 @@ fn new_command_opens_editor() {
             .write(true)
             .open(&script_path)
             .unwrap();
-        write!(script, "{}", EDITOR_COMMAND_SCRIPT).unwrap();
+        write!(script, "{EDITOR_COMMAND_SCRIPT}").unwrap();
         script.sync_all().unwrap();
         {
             use std::os::unix::fs::PermissionsExt;
@@ -64,7 +64,7 @@ fn new_command_opens_editor() {
             ]
             .into_iter(),
         )
-        .args(&[
+        .args([
             "new",
             "--interactive=false",
             "--format=yaml",
@@ -83,7 +83,7 @@ fn new_command_opens_editor() {
     drop(script_temp_dir);
 
     let unreleased_dir = temp_dir.path().join(".changelogs").join("unreleased");
-    let files = std::fs::read_dir(&unreleased_dir)
+    let files = std::fs::read_dir(unreleased_dir)
         .unwrap()
         .into_iter()
         .filter_map(|direntry| match direntry {
@@ -94,14 +94,13 @@ fn new_command_opens_editor() {
                     None
                 }
             }
-            Err(e) => panic!("Error while iterating over directory: {:?}", e),
+            Err(e) => panic!("Error while iterating over directory: {e:?}"),
         })
         .collect::<Vec<_>>();
     assert_eq!(
         files.len(),
         1,
-        "Expected 1 file to be found, found: {}: {:?}",
-        files.len(),
-        files
+        "Expected 1 file to be found, found: {}: {files:?}",
+        files.len()
     );
 }
diff --git a/tests/no_config_error.rs b/tests/no_config_error.rs
index 373a92e..dade6b3 100644
--- a/tests/no_config_error.rs
+++ b/tests/no_config_error.rs
@@ -9,7 +9,7 @@ fn no_configuration_file_errors() {
 
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["release"]) // we need some subcommand, otherwise nothing happens
+        .args(["release"]) // we need some subcommand, otherwise nothing happens
         .current_dir(&temp_dir)
         .assert()
         .failure();
@@ -22,7 +22,7 @@ fn no_configuration_file_errors_with_error_message() {
 
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["release"]) // we need some subcommand, otherwise nothing happens
+        .args(["release"]) // we need some subcommand, otherwise nothing happens
         .current_dir(&temp_dir)
         .assert()
         .stderr(predicates::str::contains(
diff --git a/tests/no_repo_error.rs b/tests/no_repo_error.rs
index 3bac5ad..8cc8be8 100644
--- a/tests/no_repo_error.rs
+++ b/tests/no_repo_error.rs
@@ -6,7 +6,7 @@ fn no_repo_errors() {
 
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["release"]) // we need some subcommand, otherwise nothing happens
+        .args(["release"]) // we need some subcommand, otherwise nothing happens
         .current_dir(&temp_dir)
         .assert()
         .failure();
@@ -18,7 +18,7 @@ fn no_repo_errors_with_no_repo_error_message() {
 
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["release"]) // we need some subcommand, otherwise nothing happens
+        .args(["release"]) // we need some subcommand, otherwise nothing happens
         .current_dir(&temp_dir)
         .assert()
         .stderr(predicates::str::contains("could not find repository"));
diff --git a/tests/release_command.rs b/tests/release_command.rs
index 1715d34..e69a94b 100644
--- a/tests/release_command.rs
+++ b/tests/release_command.rs
@@ -12,7 +12,7 @@ fn release_command_works() {
     self::common::init_cargo_changelog(temp_dir.path());
 
     self::common::cargo_changelog_new(temp_dir.path())
-        .args(&[
+        .args([
             "--format=yaml",
             "--set",
             "issue=123",
@@ -26,7 +26,7 @@ fn release_command_works() {
 
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["generate", "minor"])
+        .args(["generate", "minor"])
         .current_dir(&temp_dir)
         .assert()
         .success();
@@ -34,7 +34,7 @@ fn release_command_works() {
     // call `cargo-changelog generate`
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["release"])
+        .args(["release"])
         .current_dir(&temp_dir)
         .assert()
         .success();
@@ -57,7 +57,7 @@ fn release_command_works_for_alpha_release() {
     self::common::init_cargo_changelog(temp_dir.path());
 
     self::common::cargo_changelog_new(temp_dir.path())
-        .args(&[
+        .args([
             "--format=yaml",
             "--set",
             "issue=123",
@@ -71,7 +71,7 @@ fn release_command_works_for_alpha_release() {
 
     let unreleased_dir = temp_dir.path().join(".changelogs").join("unreleased");
 
-    let new_fragment_file_path = std::fs::read_dir(&unreleased_dir)
+    let new_fragment_file_path = std::fs::read_dir(unreleased_dir)
         .unwrap()
         .into_iter()
         .find(|rde| match rde {
@@ -95,7 +95,7 @@ fn release_command_works_for_alpha_release() {
 
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["generate", "custom", "0.1.0-alpha.1"])
+        .args(["generate", "custom", "0.1.0-alpha.1"])
         .current_dir(&temp_dir)
         .assert()
         .success();
@@ -103,7 +103,7 @@ fn release_command_works_for_alpha_release() {
     // call `cargo-changelog generate`
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["release"])
+        .args(["release"])
         .current_dir(&temp_dir)
         .assert()
         .success();
@@ -117,7 +117,7 @@ fn release_command_works_for_alpha_release() {
         panic!("Changelog is not a file");
     }
 
-    let changelog = std::fs::read_to_string(&changelog_file_path).unwrap();
+    let changelog = std::fs::read_to_string(changelog_file_path).unwrap();
     assert!(changelog.contains("0.1.0-alpha.1"));
     assert!(changelog.contains("test text"));
 }
diff --git a/tests/verify_metadata_command.rs b/tests/verify_metadata_command.rs
index 1889800..0c63842 100644
--- a/tests/verify_metadata_command.rs
+++ b/tests/verify_metadata_command.rs
@@ -10,7 +10,7 @@ fn verify_metadata_command_succeeds_with_no_changelogs() {
 
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["verify-metadata"])
+        .args(["verify-metadata"])
         .current_dir(&temp_dir)
         .assert()
         .success();
@@ -23,7 +23,7 @@ fn verify_metadata_command_succeeds_with_empty_changelog() {
     self::common::init_cargo_changelog(temp_dir.path());
 
     self::common::cargo_changelog_new(temp_dir.path())
-        .args(&[
+        .args([
             "--format=yaml",
             "--set",
             "issue=123",
@@ -37,7 +37,7 @@ fn verify_metadata_command_succeeds_with_empty_changelog() {
 
     Command::cargo_bin("cargo-changelog")
         .unwrap()
-        .args(&["verify-metadata"])
+        .args(["verify-metadata"])
         .current_dir(&temp_dir)
         .assert()
         .success();