From edc61d428c9045982030cf2b54ea20ef8cd5baab Mon Sep 17 00:00:00 2001 From: Clement Tsang <34804052+ClementTsang@users.noreply.github.com> Date: Sat, 18 Feb 2023 00:51:13 -0500 Subject: bug: fix selected text bg colour being wrong if only the fg colour was set (#1021) * rename file to be more generic * fix selected text BG colour being wrong by default * update changelog * add test for bug --- src/bin/main.rs | 2 +- src/canvas.rs | 4 +- src/canvas/canvas_colours.rs | 370 --------------------------- src/canvas/canvas_colours/colour_utils.rs | 217 ---------------- src/canvas/canvas_styling.rs | 410 ++++++++++++++++++++++++++++++ src/canvas/canvas_styling/colour_utils.rs | 192 ++++++++++++++ src/components/data_table/styling.rs | 2 +- src/options.rs | 2 +- src/widgets/cpu_graph.rs | 2 +- src/widgets/disk_table.rs | 2 +- src/widgets/process_table.rs | 2 +- src/widgets/temperature_table.rs | 2 +- 12 files changed, 611 insertions(+), 596 deletions(-) delete mode 100644 src/canvas/canvas_colours.rs delete mode 100644 src/canvas/canvas_colours/colour_utils.rs create mode 100644 src/canvas/canvas_styling.rs create mode 100644 src/canvas/canvas_styling/colour_utils.rs (limited to 'src') diff --git a/src/bin/main.rs b/src/bin/main.rs index 328cd7a0..946ca1aa 100644 --- a/src/bin/main.rs +++ b/src/bin/main.rs @@ -19,7 +19,7 @@ use std::{ use anyhow::{Context, Result}; use bottom::{ - canvas::{self, canvas_colours::CanvasColours}, + canvas::{self, canvas_styling::CanvasColours}, constants::*, data_conversion::*, options::*, diff --git a/src/canvas.rs b/src/canvas.rs index b1eca362..9ac75585 100644 --- a/src/canvas.rs +++ b/src/canvas.rs @@ -1,6 +1,6 @@ use std::str::FromStr; -use canvas_colours::*; +use canvas_styling::*; use itertools::izip; use tui::{ backend::Backend, @@ -21,7 +21,7 @@ use crate::{ utils::error::BottomError, }; -pub mod canvas_colours; +pub mod canvas_styling; mod dialogs; mod drawing_utils; mod widgets; diff --git a/src/canvas/canvas_colours.rs b/src/canvas/canvas_colours.rs deleted file mode 100644 index e7996a32..00000000 --- a/src/canvas/canvas_colours.rs +++ /dev/null @@ -1,370 +0,0 @@ -use std::borrow::Cow; - -use anyhow::Context; -use colour_utils::*; -use tui::style::{Color, Style}; - -use super::ColourScheme; -use crate::{ - constants::*, - options::{Config, ConfigColours}, - utils::error, -}; -mod colour_utils; - -pub struct CanvasColours { - pub currently_selected_text_colour: Color, - pub currently_selected_bg_colour: Color, - pub currently_selected_text_style: Style, - pub table_header_style: Style, - pub ram_style: Style, - pub swap_style: Style, - pub arc_style: Style, - pub gpu_colour_styles: Vec