| Age | Commit message (Collapse) | Author |
|---|
|
Refactor to split up data collection by OS and/or the backing library. The goal is to make it easier to work with and add new OS support, as opposed to how it was prior where we stored OS-independent implementations all in the same file.
|
|
Tweak PR CI a bit more. Remove complete step, change check name, add comments.
|
|
Hopefully fixes the mock build capabilities for nightly when testing.
|
|
|
|
Switch the Linux proc parts to the procfs library: https://crates.io/crates/procfs.
|
|
|
|
Moves cargo test into the cargo check block.
|
|
Since we're moving all 16.04 ubuntu builds to 18.04, I thought this would be a good idea in case anyone needed it.
Not sure if we should have just made ALL Linux builds use the older Linux container... for now I'll just make one extra build.
|
|
Updates ubuntu version in CI due to GA deprecation warnings.
|
|
|
|
Adds a line to actually build the string of the summed memory usage. I forgot to make the string after summing the values.
|
|
|
|
Removes `strip` from the Windows build in deploy/nightly. It seems to cause VirusTotal to report some false positives.
|
|
|
|
|
|
|
|
|
|
Update versions to 0.6.0.
|
|
Updates the demo gif in the README for 0.6.0.
|
|
|
|
Lowers the timer for multi-digit inputs in dd.
I'm going to eventually completely rewrite the input part for the entire application though, but this will do for now.
|
|
Due to #404, I've just moved all CPU usage calculations over to heim.
|
|
Did not update crossterm (and tui-rs) since it seems to have resulted in a massive CPU usage increase. Also fix minor clippy error with a duplicated to_string call.
|
|
|
|
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
|
|
|
We make the advanced kill menu the default instead. You can opt out with disable_advanced_kill.
|
|
Adds advanced_kill to the default config gen.
|
|
Removes the .vscode folder.
|
|
Removes the gap between the CPU section and other columns in basic mode.
|
|
Fixes the mouse hitbox checks overextending by 1. Also reverts the bandaid fix done for #458.
|
|
Fixes basic mode having broken click hitboxes (they were 1 unit too long in both directions). I'm pretty sure normal mode does too, but it's less noticeable due to bounding boxes.
|
|
*Total -- 76.76kb -> 58.86kb (23.32%)
/assets/disk_name_mount_filter.png -- 24.58kb -> 17.70kb (27.97%)
/assets/disk_no_filter.png -- 36.56kb -> 28.63kb (21.7%)
/assets/disk_name_filter.png -- 15.62kb -> 12.53kb (19.8%)
Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
|
|
Refactor in regards to clippy nightly. Mostly deals with suggestions with duplicate code on multiple branches.
|
|
This PR accomplishes two things:
1. This PR aims to add mount_filter to the config file. This allows a user to filter their disk widget entries by the mount name as well; this was particularly a problem in trying to address #431.
2. A slight rework of how the filter system works due to the need of being able to manage two potentially conflicting filter sources, since the disk widget will now potentially filter on both the disk name and the mount name.
In regards to the second point, the new behaviour is as such:
1. Is the entry allowed through any filter? That is, does it match an entry in a filter where is_list_ignored is false? If so, we always keep this entry.
2. Is the entry denied through any filter? That is, does it match an entry in a filter where is_list_ignored is true? If so, we always deny this entry.
3. Anything else is allowed.
This main (breaking) change is really the third point. This would mean that temp_filter and net_filter, when set to allow listed entries with is_list_ignored = false, are kinda... useless, as a whitelist in the scenario of being the only filter is kinda pointless. But hopefully this shouldn't be a problem...?
|
|
Adds nord and nord-light as part of the description in the pre-defined config file.
|
|
A bit of a followup to #449, this adds decimal places for values over 1GB in regards to disk usage. This affects the disk widget (for the read/write per second) and process widgets (total read, total write, read/write per second).
|
|
Removes/tweaks some really light colours that might cause issues with a white background. For example, yellow on white didn't look so great, so I adjusted the memory/rx colours for this mode.
|
|
This change adds a decimal + single digit to memory usage values over the 1 GiB threshold. Otherwise, there is no visible change.
(Note to self: implement the per-column width system soon, this change causes some values to potentially look a bit weird in mem-non-percent mode as it is if the value is really large, like 530.2GiB pushing right up against the column width, but it's currently tied to mem-percent mode. Ugh.)
Also revert a change made by accident where I switched to a decimal prefix system (GB) for memory values. This has been reverted back to a binary prefix (GiB).
|
|
|
|
Refactor to unify the process disk usage -> string into one function.
|
|
For the process widget, we now sum the resource usage of the child processes on the parent entry when collapsing in tree mode.
Note that if you search to filter, and collapse, it will not sum the pruned values (values that cannot be seen). This is partly because I'm a bit lazy, and partly because I think this behaviour makes sense.
For example, let's say I search for a process with 4 child processes "AA, AB, BA, BB", with CPU usage 0.1, 0.2, 0.3, 0.4 respectively. Assume the parent process has 0 usage.
- Without filter, it sums to 1.0
- With a filter on A, it would sum to just 0.3
- With a filter on AA, it would sum to 0.1
I think this is fine because I'm treating this as summing any child that is still *visible* somehow. Summing unseen values would probably be weird as it would look like it's not adding up.
Further note that if you had, say, a child "CC" with a usage of, say, 2.0, and its parent of "AB", and you searched for CC in our above example, you would get a sum of 2.2. This is because AB is still visible by the fact that CC was the searched process, and AB must still exist (albeit faded out) in the tree hierarchy, and as such will still be displayed.
|
|
Switches to fxhash from fnv, which should be a bit faster.
|
|
In particular, use non-binary prefixes for disk and memory usage in a process. Ideally everything is configurable by the user, but this is fine for now IMO until I can get around to doing in-app config.
|
|
Rewrite of the y-axis labeling and scaling for the network widget, along with more customization. This still has one step to be optimized (cache results so we don't have to recalculate the legend each time), but will be done in another PR for sake of this one being too large already.
Furthermore, this change adds linear interpolation at the 0 point in the case a data point shoots too far back - this seems to have lead to ugly gaps to the left of graphs in some cases, because the left hand limit was not big enough for the data point. We address this by grabbing values just outside the time range and linearly interpolating at the leftmost limit. This affects all graph widgets (CPU, mem, network).
This can be optimized, and will hopefully be prior to release in a separate change.
|
|
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
|
Fixes a rare segfault if a uid does not have a passwd entry. The unsafe block at https://github.com/ClementTsang/bottom/blob/master/src/app/data_harvester/processes.rs#L137 can return a null pointer as specified at https://www.gnu.org/software/libc/manual/html_node/Lookup-User.html.
|
|
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
|
|
|
|
