diff options
| author | Clement Tsang <34804052+ClementTsang@users.noreply.github.com> | 2020-12-10 22:29:25 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-12-10 22:29:25 -0500 |
| commit | fd003f84da5582327a9d34ce82b01d2b3b5bf353 (patch) | |
| tree | c7e29d956b3f4ac311befa480d63db81cfa2f01d /src/clap.rs | |
| parent | 030f4ddd6a9b48050215f5513883fa0d4f167c47 (diff) | |
bug: Fix some performance regressions (#344)
Fixes some performance regressions and forgotten cleanup.
Changes to attempt to improve performance to match 0.4.x:
- Remove `trace!` and `--debug` for now. These were a significant hog. Removing this dropped initial memory usage by about half.
- Add additional cleaning step for `pid_mapping` during process harvesting. This should hopefully improve memory usage as time goes on.
- Slightly change how we do sorting to hopefully be a bit more optimal? This was just an easy change to make that I spotted.
- Fix broken cleaning child thread task.
Diffstat (limited to 'src/clap.rs')
| -rw-r--r-- | src/clap.rs | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/src/clap.rs b/src/clap.rs index 3a50ee54..1e6d1087 100644 --- a/src/clap.rs +++ b/src/clap.rs @@ -81,13 +81,14 @@ custom layouts.\n\n", "\ When searching for a process, enables case sensitivity by default.\n\n", ); - let debug = Arg::with_name("debug") - .long("debug") - .help("Enables debug logging.") - .long_help( - "\ -Enables debug logging. The program will print where it logged to after running.", - ); + // TODO: [DEBUG] Add a proper debugging solution. + // let debug = Arg::with_name("debug") + // .long("debug") + // .help("Enables debug logging.") + // .long_help( + // "\ + // Enables debug logging. The program will print where it logged to after running.", + // ); // TODO: [DIAGNOSE] Add a diagnose option to help with debugging. let disable_click = Arg::with_name("disable_click") .long("disable_click") @@ -362,7 +363,7 @@ Defaults to showing the process widget in tree mode.\n\n", .arg(case_sensitive) .arg(config_location) .arg(color) - .arg(debug) + // .arg(debug) .arg(mem_as_value) .arg(default_time_value) .arg(default_widget_count) |