summaryrefslogtreecommitdiffstats
path: root/src/canvas
diff options
context:
space:
mode:
authorClement Tsang <34804052+ClementTsang@users.noreply.github.com>2020-09-26 20:04:34 -0400
committerClementTsang <cjhtsang@uwaterloo.ca>2020-09-26 20:21:59 -0400
commit750d8f3cb747103cca7a2a4afe8ff41ff1318b6f (patch)
treeac34a6a538c1f94cb395b20a23c9186b749ca6e6 /src/canvas
parent6db76029e2419d53c81cb2111e487f83ee248a2f (diff)
refactor: tui-rs 0.11.0 refactor (#253)
Refactors tui-rs usage to the new 0.11.0 release. This release also fixes the highlighting bug from #249, and now, expanding a widget no longer overrides the widget title colour. This commit also introduces #255, but that seems to be easy to bandaid so hopefully it will get fixed soon?
Diffstat (limited to 'src/canvas')
-rw-r--r--src/canvas/dialogs/dd_dialog.rs106
-rw-r--r--src/canvas/dialogs/help_dialog.rs36
-rw-r--r--src/canvas/screens/config_screen.rs6
-rw-r--r--src/canvas/widgets/basic_table_arrows.rs22
-rw-r--r--src/canvas/widgets/battery_display.rs154
-rw-r--r--src/canvas/widgets/cpu_basic.rs20
-rw-r--r--src/canvas/widgets/cpu_graph.rs64
-rw-r--r--src/canvas/widgets/disk_table.rs67
-rw-r--r--src/canvas/widgets/mem_basic.rs12
-rw-r--r--src/canvas/widgets/mem_graph.rs68
-rw-r--r--src/canvas/widgets/network_basic.rs26
-rw-r--r--src/canvas/widgets/network_graph.rs65
-rw-r--r--src/canvas/widgets/process_table.rs120
-rw-r--r--src/canvas/widgets/temp_table.rs39
14 files changed, 372 insertions, 433 deletions
diff --git a/src/canvas/dialogs/dd_dialog.rs b/src/canvas/dialogs/dd_dialog.rs
index 11d0df5f..50dbc7ef 100644
--- a/src/canvas/dialogs/dd_dialog.rs
+++ b/src/canvas/dialogs/dd_dialog.rs
@@ -2,7 +2,8 @@ use tui::{
backend::Backend,
layout::{Alignment, Constraint, Direction, Layout, Rect},
terminal::Frame,
- widgets::{Block, Borders, Paragraph, Text},
+ text::{Span, Spans, Text},
+ widgets::{Block, Borders, Paragraph, Wrap},
};
use crate::{app::App, canvas::Painter};
@@ -11,46 +12,46 @@ const DD_BASE: &str = " Confirm Kill Process ── Esc to close ";
const DD_ERROR_BASE: &str = " Error ── Esc to close ";
pub trait KillDialog {
- fn get_dd_spans(&self, app_state: &App) -> Option<Vec<Text<'_>>>;
+ fn get_dd_spans(&self, app_state: &App) -> Option<Text<'_>>;
fn draw_dd_dialog<B: Backend>(
- &self, f: &mut Frame<'_, B>, dd_text: Option<Vec<Text<'_>>>, app_state: &mut App,
- draw_loc: Rect,
+ &self, f: &mut Frame<'_, B>, dd_text: Option<Text<'_>>, app_state: &mut App, draw_loc: Rect,
) -> bool;
}
impl KillDialog for Painter {
- fn get_dd_spans(&self, app_state: &App) -> Option<Vec<Text<'_>>> {
+ fn get_dd_spans(&self, app_state: &App) -> Option<Text<'_>> {
if let Some(dd_err) = &app_state.dd_err {
- return Some(vec![
- Text::raw("\n"),
- Text::raw(format!("Failed to kill process.\n{}\n", dd_err)),
- Text::raw("Please press ENTER or ESC to close this dialog."),
- ]);
+ return Some(Text::from(vec![
+ Spans::default(),
+ Spans::from("Failed to kill process."),
+ Spans::from(dd_err.clone()),
+ Spans::from("Please press ENTER or ESC to close this dialog."),
+ ]));
} else if let Some(to_kill_processes) = app_state.get_to_delete_processes() {
if let Some(first_pid) = to_kill_processes.1.first() {
- return Some(vec![
- Text::raw("\n"),
+ return Some(Text::from(vec![
+ Spans::from(""),
if app_state.is_grouped(app_state.current_widget.widget_id) {
if to_kill_processes.1.len() != 1 {
- Text::raw(format!(
+ Spans::from(format!(
"Kill {} processes with the name \"{}\"? Press ENTER to confirm.",
to_kill_processes.1.len(),
to_kill_processes.0
))
} else {
- Text::raw(format!(
+ Spans::from(format!(
"Kill 1 process with the name \"{}\"? Press ENTER to confirm.",
to_kill_processes.0
))
}
} else {
- Text::raw(format!(
+ Spans::from(format!(
"Kill process \"{}\" with PID {}? Press ENTER to confirm.",
to_kill_processes.0, first_pid
))
},
- ]);
+ ]));
}
}
@@ -58,63 +59,44 @@ impl KillDialog for Painter {
}
fn draw_dd_dialog<B: Backend>(
- &self, f: &mut Frame<'_, B>, dd_text: Option<Vec<Text<'_>>>, app_state: &mut App,
- draw_loc: Rect,
+ &self, f: &mut Frame<'_, B>, dd_text: Option<Text<'_>>, app_state: &mut App, draw_loc: Rect,
) -> bool {
if let Some(dd_text) = dd_text {
- // let dd_title = if app_state.dd_err.is_some() {
- // Text::styled(
- // format!(
- // " Error ─{}─ Esc to close ",
- // "─".repeat(
- // usize::from(draw_loc.width)
- // .saturating_sub(DD_ERROR_BASE.chars().count() + 2)
- // )
- // ),
- // self.colours.border_style,
- // )
- // } else {
- // Text::styled(
- // format!(
- // " Confirm Kill Process ─{}─ Esc to close ",
- // "─".repeat(
- // usize::from(draw_loc.width).saturating_sub(DD_BASE.chars().count() + 2)
- // )
- // ),
- // self.colours.border_style,
- // )
- // };
-
let dd_title = if app_state.dd_err.is_some() {
- format!(
- " Error ─{}─ Esc to close ",
- "─".repeat(
- usize::from(draw_loc.width)
- .saturating_sub(DD_ERROR_BASE.chars().count() + 2)
- )
+ Span::styled(
+ format!(
+ " Error ─{}─ Esc to close ",
+ "─".repeat(
+ usize::from(draw_loc.width)
+ .saturating_sub(DD_ERROR_BASE.chars().count() + 2)
+ )
+ ),
+ self.colours.border_style,
)
} else {
- format!(
- " Confirm Kill Process ─{}─ Esc to close ",
- "─".repeat(
- usize::from(draw_loc.width).saturating_sub(DD_BASE.chars().count() + 2)
- )
+ Span::styled(
+ format!(
+ " Confirm Kill Process ─{}─ Esc to close ",
+ "─".repeat(
+ usize::from(draw_loc.width).saturating_sub(DD_BASE.chars().count() + 2)
+ )
+ ),
+ self.colours.border_style,
)
};
f.render_widget(
- Paragraph::new(dd_text.iter())
+ Paragraph::new(dd_text)
.block(
Block::default()
- .title(&dd_title)
- .title_style(self.colours.border_style)
+ .title(dd_title)
.style(self.colours.border_style)
.borders(Borders::ALL)
.border_style(self.colours.border_style),
)
.style(self.colours.text_style)
.alignment(Alignment::Center)
- .wrap(true),
+ .wrap(Wrap { trim: true }),
draw_loc,
);
@@ -135,13 +117,13 @@ impl KillDialog for Painter {
if let Some(button_draw_loc) = split_draw_loc.get(1) {
let (yes_button, no_button) = if app_state.delete_dialog_state.is_on_yes {
(
- Text::styled("Yes", self.colours.currently_selected_text_style),
- Text::raw("No"),
+ Span::styled("Yes", self.colours.currently_selected_text_style),
+ Span::raw("No"),
)
} else {
(
- Text::raw("Yes"),
- Text::styled("No", self.colours.currently_selected_text_style),
+ Span::raw("Yes"),
+ Span::styled("No", self.colours.currently_selected_text_style),
)
};
@@ -158,13 +140,13 @@ impl KillDialog for Painter {
.split(*button_draw_loc);
f.render_widget(
- Paragraph::new([yes_button].iter())
+ Paragraph::new(yes_button)
.block(Block::default())
.alignment(Alignment::Right),
button_layout[0],
);
f.render_widget(
- Paragraph::new([no_button].iter())
+ Paragraph::new(no_button)
.block(Block::default())
.alignment(Alignment::Left),
button_layout[2],
diff --git a/src/canvas/dialogs/help_dialog.rs b/src/canvas/dialogs/help_dialog.rs
index fe0f1c52..752dc858 100644
--- a/src/canvas/dialogs/help_dialog.rs
+++ b/src/canvas/dialogs/help_dialog.rs
@@ -5,7 +5,8 @@ use tui::{
backend::Backend,
layout::{Alignment, Rect},
terminal::Frame,
- widgets::{Block, Borders, Paragraph},
+ text::Span,
+ widgets::{Block, Borders, Paragraph, Wrap},
};
const HELP_BASE: &str = " Help ── Esc to close ";
@@ -21,19 +22,14 @@ impl HelpDialog for Painter {
fn draw_help_dialog<B: Backend>(
&self, f: &mut Frame<'_, B>, app_state: &mut App, draw_loc: Rect,
) {
- // let help_title = Text::styled(
- // format!(
- // " Help ─{}─ Esc to close ",
- // "─".repeat(
- // usize::from(draw_loc.width).saturating_sub(HELP_BASE.chars().count() + 2)
- // )
- // ),
- // self.colours.border_style,
- // );
-
- let help_title = format!(
- " Help ─{}─ Esc to close ",
- "─".repeat(usize::from(draw_loc.width).saturating_sub(HELP_BASE.chars().count() + 2))
+ let help_title = Span::styled(
+ format!(
+ " Help ─{}─ Esc to close ",
+ "─".repeat(
+ usize::from(draw_loc.width).saturating_sub(HELP_BASE.chars().count() + 2)
+ )
+ ),
+ self.colours.border_style,
);
if app_state.should_get_widget_bounds() {
@@ -99,24 +95,24 @@ impl HelpDialog for Painter {
}
f.render_widget(
- Paragraph::new(self.styled_help_text.iter())
+ Paragraph::new(self.styled_help_text.clone())
.block(
Block::default()
- .title(&help_title)
- .title_style(self.colours.border_style)
+ .title(help_title)
.style(self.colours.border_style)
.borders(Borders::ALL)
.border_style(self.colours.border_style),
)
.style(self.colours.text_style)
.alignment(Alignment::Left)
- .wrap(true)
- .scroll(
+ .wrap(Wrap { trim: true })
+ .scroll((
app_state
.help_dialog_state
.scroll_state
.current_scroll_index,
- ),
+ 0,
+ )),
draw_loc,
);
}
diff --git a/src/canvas/screens/config_screen.rs b/src/canvas/screens/config_screen.rs
index 6aa22493..161e6ca6 100644
--- a/src/canvas/screens/config_screen.rs
+++ b/src/canvas/screens/config_screen.rs
@@ -1,3 +1,5 @@
+#![allow(unused_variables)] //FIXME: Remove this
+#![allow(unused_imports)] //FIXME: Remove this
use crate::{app::App, canvas::Painter, constants};
use tui::{
backend::Backend,
@@ -6,6 +8,7 @@ use tui::{
layout::Layout,
layout::{Alignment, Rect},
terminal::Frame,
+ text::Span,
widgets::{Block, Borders, Paragraph},
};
@@ -20,8 +23,7 @@ impl ConfigScreen for Painter {
&self, f: &mut Frame<'_, B>, app_state: &mut App, draw_loc: Rect,
) {
let config_block = Block::default()
- .title(&" Config ")
- .title_style(self.colours.border_style)
+ .title(" Config ") // FIXME: [Config] missing title styling
.style(self.colours.border_style)
.borders(Borders::ALL)
.border_style(self.colours.border_style);
diff --git a/src/canvas/widgets/basic_table_arrows.rs b/src/canvas/widgets/basic_table_arrows.rs
index fd64e8dc..bce169e1 100644
--- a/src/canvas/widgets/basic_table_arrows.rs
+++ b/src/canvas/widgets/basic_table_arrows.rs
@@ -7,7 +7,9 @@ use tui::{
backend::Backend,
layout::{Alignment, Constraint, Direction, Layout, Rect},
terminal::Frame,
- widgets::{Block, Paragraph, Text},
+ text::Span,
+ text::Spans,
+ widgets::{Block, Paragraph},
};
pub trait BasicTableArrows {
@@ -97,13 +99,19 @@ impl BasicTableArrows for Painter {
usize::from(draw_loc.width).saturating_sub(6 + left_name.len() + right_name.len());
let left_arrow_text = vec![
- Text::raw("\n"),
- Text::styled(format!("◄ {}", left_name), self.colours.text_style),
+ Spans::default(),
+ Spans::from(Span::styled(
+ format!("◄ {}", left_name),
+ self.colours.text_style,
+ )),
];
let right_arrow_text = vec![
- Text::raw("\n"),
- Text::styled(format!("{} ►", right_name), self.colours.text_style),
+ Spans::default(),
+ Spans::from(Span::styled(
+ format!("{} ►", right_name),
+ self.colours.text_style,
+ )),
];
let margined_draw_loc = Layout::default()
@@ -120,11 +128,11 @@ impl BasicTableArrows for Painter {
.split(draw_loc);
f.render_widget(
- Paragraph::new(left_arrow_text.iter()).block(Block::default()),
+ Paragraph::new(left_arrow_text).block(Block::default()),
margined_draw_loc[0],
);
f.render_widget(
- Paragraph::new(right_arrow_text.iter())
+ Paragraph::new(right_arrow_text)
.block(Block::default())
.alignment(Alignment::Right),
margined_draw_loc[2],
diff --git a/src/canvas/widgets/battery_display.rs b/src/canvas/widgets/battery_display.rs
index e50ed515..7364044b 100644
--- a/src/canvas/widgets/battery_display.rs
+++ b/src/canvas/widgets/battery_display.rs
@@ -8,8 +8,10 @@ use tui::{
backend::Backend,
layout::{Constraint, Direction, Layout, Rect},
terminal::Frame,
- widgets::{Block, Borders, Paragraph, Row, Table, Tabs, Text},
+ text::{Span, Spans},
+ widgets::{Block, Borders, Paragraph, Row, Table, Tabs},
};
+use unicode_segmentation::UnicodeSegmentation;
pub trait BatteryDisplayWidget {
fn draw_battery_display<B: Backend>(
@@ -28,53 +30,38 @@ impl BatteryDisplayWidget for Painter {
app_state.battery_state.widget_states.get_mut(&widget_id)
{
let is_on_widget = widget_id == app_state.current_widget.widget_id;
- let border_and_title_style = if is_on_widget {
+ let border_style = if is_on_widget {
self.colours.highlighted_border_style
} else {
self.colours.border_style
};
- // let title = if app_state.is_expanded {
- // const TITLE_BASE: &str = " Battery ── Esc to go back ";
- // Span::styled(
- // format!(
- // " Battery ─{}─ Esc to go back ",
- // "─".repeat(
- // usize::from(draw_loc.width)
- // .saturating_sub(TITLE_BASE.chars().count() + 2)
- // )
- // ),
- // border_and_title_style,
- // )
- // } else {
- // Span::styled(" Battery ".to_string(), self.colours.widget_title_style)
- // };
-
let title = if app_state.is_expanded {
const TITLE_BASE: &str = " Battery ── Esc to go back ";
-
- format!(
- " Battery ─{}─ Esc to go back ",
- "─".repeat(
- usize::from(draw_loc.width).saturating_sub(TITLE_BASE.chars().count() + 2)
- )
- )
+ Spans::from(vec![
+ Span::styled(" Battery ".to_string(), self.colours.widget_title_style),
+ Span::styled(
+ format!(
+ "─{}─ Esc to go back ",
+ "─".repeat(usize::from(draw_loc.width).saturating_sub(
+ UnicodeSegmentation::graphemes(TITLE_BASE, true).count() + 2
+ ))
+ ),
+ border_style,
+ ),
+ ])
} else {
- " Battery ".to_string()
- };
-
- let title_style = if app_state.is_expanded {
- border_and_title_style
- } else {
- self.colours.widget_title_style
+ Spans::from(Span::styled(
+ " Battery ".to_string(),
+ self.colours.widget_title_style,
+ ))
};
let battery_block = if draw_border {
Block::default()
- .title(&title)
- .title_style(title_style)
+ .title(title)
.borders(Borders::ALL)
- .border_style(border_and_title_style)
+ .border_style(border_style)
} else if is_on_widget {
Block::default()
.borders(*SIDE_BORDERS)
@@ -83,38 +70,12 @@ impl BatteryDisplayWidget for Painter {
Block::default().borders(Borders::NONE)
};
- // f.render_widget(
- // // Tabs::new(
- // // (app_state
- // // .canvas_data
- // // .battery_data
- // // .iter()
- // // .map(|battery| Spans::from(battery.battery_name.clone())))
- // // .collect::<Vec<_>>(),
- // // )
- // Tabs::default()
- // .titles(
- // app_state
- // .canvas_data
- // .battery_data
- // .iter()
- // .map(|battery| &battery.battery_name)
- // .collect::<Vec<_>>()
- // .as_ref(),
- // )
- // .block(battery_block)
- // .divider(tui::symbols::line::VERTICAL)
- // .style(self.colours.text_style)
- // .highlight_style(self.colours.currently_selected_text_style)
- // .select(battery_widget_state.currently_selected_battery_index),
- // draw_loc,
- // );
-
- let margined_draw_loc = Layout::default()
- .constraints([Constraint::Percentage(100)].as_ref())
- .horizontal_margin(if is_on_widget || draw_border { 0 } else { 1 })
- .direction(Direction::Horizontal)
- .split(draw_loc)[0];
+ let battery_names = app_state
+ .canvas_data
+ .battery_data
+ .iter()
+ .map(|battery| &battery.battery_name)
+ .collect::<Vec<_>>();
let tab_draw_loc = Layout::default()
.constraints(
@@ -128,6 +89,27 @@ impl BatteryDisplayWidget for Painter {
.direction(Direction::Vertical)
.split(draw_loc)[1];
+ f.render_widget(
+ Tabs::new(
+ battery_names
+ .iter()
+ .map(|name| Spans::from((*name).clone()))
+ .collect::<Vec<_>>(),
+ )
+ .block(Block::default())
+ .divider(tui::symbols::line::VERTICAL)
+ .style(self.colours.text_style)
+ .highlight_style(self.colours.currently_selected_text_style)
+ .select(battery_widget_state.currently_selected_battery_index),
+ tab_draw_loc,
+ );
+
+ let margined_draw_loc = Layout::default()
+ .constraints([Constraint::Percentage(100)].as_ref())
+ .horizontal_margin(if is_on_widget || draw_border { 0 } else { 1 })
+ .direction(Direction::Horizontal)
+ .split(draw_loc)[0];
+
if let Some(battery_details) = app_state
.canvas_data
.battery_data
@@ -189,45 +171,15 @@ impl BatteryDisplayWidget for Painter {
);
} else {
f.render_widget(
- Paragraph::new(
- [Text::styled(
- "No data found for this battery",
- self.colours.text_style,
- )]
- .iter(),
- )
+ Paragraph::new(Span::styled(
+ "No data found for this battery",
+ self.colours.text_style,
+ ))
.block(battery_block),
margined_draw_loc,
);
}
- let battery_names = app_state
- .canvas_data
- .battery_data
- .iter()
- .map(|battery| &battery.battery_name)
- .collect::<Vec<_>>();
-
- // Has to be placed AFTER for tui 0.9, place BEFORE for 0.10.
- f.render_widget(
- // Tabs::new(
- // (app_state
- // .canvas_data
- // .battery_data
- // .iter()
- // .map(|battery| Spans::from(battery.battery_name.clone())))
- // .collect::<Vec<_>>(),
- // )
- Tabs::default()
- .titles(battery_names.as_ref())
- .block(Block::default())
- .divider(tui::symbols::line::VERTICAL)
- .style(self.colours.text_style)
- .highlight_style(self.colours.currently_selected_text_style) //FIXME: [HIGHLIGHT] THIS IS BROKEN ON TUI's SIDE, override this with your own style...
- .select(battery_widget_state.currently_selected_battery_index),
- tab_draw_loc,
- );
-
if should_get_widget_bounds {
// Tab wizardry
if !battery_names.is_empty() {
diff --git a/src/canvas/widgets/cpu_basic.rs b/src/canvas/widgets/cpu_basic.rs
index 7f9381f9..2f7574b6 100644
--- a/src/canvas/widgets/cpu_basic.rs
+++ b/src/canvas/widgets/cpu_basic.rs
@@ -11,7 +11,8 @@ use tui::{
backend::Backend,
layout::{Constraint, Direction, Layout, Rect},
terminal::Frame,
- widgets::{Block, Paragraph, Text},
+ text::{Span, Spans},
+ widgets::{Block, Paragraph},
};
pub trait CpuBasicWidget {
@@ -76,7 +77,7 @@ impl CpuBasicWidget for Painter {
let num_bars = calculate_basic_use_bars(use_percentage, bar_length);
format!(
- "{:3}[{}{}{:3.0}%]\n",
+ "{:3}[{}{}{:3.0}%]",
if app_state.app_config_fields.show_average_cpu {
if cpu_index == 0 {
"AVG".to_string()
@@ -108,16 +109,11 @@ impl CpuBasicWidget for Painter {
let end_index = min(start_index + how_many_cpus, num_cpus);
let cpu_column = (start_index..end_index)
.map(|cpu_index| {
- // Spans::from(Span {
- // content: (&cpu_bars[cpu_index]).into(),
- // style: self.colours.cpu_colour_styles
- // [cpu_index % self.colours.cpu_colour_styles.len()],
- // })
- Text::styled(
- &cpu_bars[cpu_index],
- self.colours.cpu_colour_styles
+ Spans::from(Span {
+ content: (&cpu_bars[cpu_index]).into(),
+ style: self.colours.cpu_colour_styles
[cpu_index % self.colours.cpu_colour_styles.len()],
- )
+ })
})
.collect::<Vec<_>>();
@@ -130,7 +126,7 @@ impl CpuBasicWidget for Painter {
.split(*chunk)[0];
f.render_widget(
- Paragraph::new(cpu_column.iter()).block(Block::default()),
+ Paragraph::new(cpu_column).block(Block::default()),
margined_loc,
);
}
diff --git a/src/canvas/widgets/cpu_graph.rs b/src/canvas/widgets/cpu_graph.rs
index 97ba064d..07fdfaf0 100644
--- a/src/canvas/widgets/cpu_graph.rs
+++ b/src/canvas/widgets/cpu_graph.rs
@@ -1,5 +1,6 @@
use lazy_static::lazy_static;
use std::borrow::Cow;
+use unicode_segmentation::UnicodeSegmentation;
use crate::{
app::{layout_manager::WidgetDirection, App},
@@ -16,6 +17,8 @@ use tui::{
layout::{Constraint, Direction, Layout, Rect},
symbols::Marker,
terminal::Frame,
+ text::Span,
+ text::Spans,
widgets::{Axis, Block, Borders, Chart, Dataset, Row, Table},
};
@@ -135,17 +138,17 @@ impl CpuGraphWidget for Painter {
if let Some(cpu_widget_state) = app_state.cpu_state.widget_states.get_mut(&widget_id) {
let cpu_data: &mut [ConvertedCpuData] = &mut app_state.canvas_data.cpu_data;
- // let display_time_labels = vec![
- // Text::styled(
- // format!("{}s", cpu_widget_state.current_display_time / 1000),
- // self.colours.graph_style,
- // ),
- // Text::styled("0s".to_string(), self.colours.graph_style),
- // ];
+ let display_time_labels = vec![
+ Span::styled(
+ format!("{}s", cpu_widget_state.current_display_time / 1000),
+ self.colours.graph_style,
+ ),
+ Span::styled("0s".to_string(), self.colours.graph_style),
+ ];
- let display_time_labels = [
- format!("{}s", cpu_widget_state.current_display_time / 1000),
- "0s".to_string(),
+ let y_axis_labels = vec![
+ Span::styled("0%", self.colours.graph_style),
+ Span::styled("100%", self.colours.graph_style),
];
let x_axis = if app_state.app_config_fields.hide_time
@@ -160,8 +163,7 @@ impl CpuGraphWidget for Painter {
Axis::default()
.bounds([-(cpu_widget_state.current_display_time as f64), 0.0])
.style(self.colours.graph_style)
- .labels(&display_time_labels)
- .labels_style(self.colours.graph_style)
+ .labels(display_time_labels)
} else {
cpu_widget_state.autohide_timer = None;
Axis::default().bounds([-(cpu_widget_state.current_display_time as f64), 0.0])
@@ -172,15 +174,13 @@ impl CpuGraphWidget for Painter {
Axis::default()
.bounds([-(cpu_widget_state.current_display_time as f64), 0.0])
.style(self.colours.graph_style)
- .labels(&display_time_labels)
- .labels_style(self.colours.graph_style)
+ .labels(display_time_labels)
};
let y_axis = Axis::default()
.style(self.colours.graph_style)
.bounds([0.0, 100.5])
- .labels_style(self.colours.graph_style)
- .labels(&["0%", "100%"]);
+ .labels(y_axis_labels);
let use_dot = app_state.app_config_fields.use_dot;
let show_avg_cpu = app_state.app_config_fields.show_average_cpu;
@@ -228,32 +228,36 @@ impl CpuGraphWidget for Painter {
vec![]
};
- let border_style = if app_state.current_widget.widget_id == widget_id {
+ let is_on_widget = widget_id == app_state.current_widget.widget_id;
+ let border_style = if is_on_widget {
self.colours.highlighted_border_style
} else {
self.colours.border_style
};
- // let title = if app_state.is_expanded {
- // Span::styled(" CPU ".to_string(), border_style)
- // } else {
- // Span::styled(" CPU ".to_string(), self.colours.widget_title_style)
- // };
- let title = " CPU ";
- let title_style = if app_state.is_expanded {
- border_style
+ let title = if app_state.is_expanded {
+ const TITLE_BASE: &str = " CPU ── Esc to go back ";
+ Spans::from(vec![
+ Span::styled(" CPU ", self.colours.widget_title_style),
+ Span::styled(
+ format!(
+ "─{}─ Esc to go back ",
+ "─".repeat(usize::from(draw_loc.width).saturating_sub(
+ UnicodeSegmentation::graphemes(TITLE_BASE, true).count() + 2
+ ))
+ ),
+ border_style,
+ ),
+ ])
} else {
- self.colours.widget_title_style
+ Spans::from(Span::styled(" CPU ", self.colours.widget_title_style))
};
f.render_widget(
- // Chart::new(dataset_vector)
- Chart::default()
- .datasets(&dataset_vector)
+ Chart::new(dataset_vector)
.block(
Block::default()
.title(title)
- .title_style(title_style)
.borders(Borders::ALL)
.border_style(border_style),
)
diff --git a/src/canvas/widgets/disk_table.rs b/src/canvas/widgets/disk_table.rs
index 440687df..091b58c9 100644
--- a/src/canvas/widgets/disk_table.rs
+++ b/src/canvas/widgets/disk_table.rs
@@ -3,6 +3,8 @@ use tui::{
backend::Backend,
layout::{Constraint, Direction, Layout, Rect},
terminal::Frame,
+ text::Span,
+ text::Spans,
widgets::{Block, Borders, Row, Table},
};
@@ -139,19 +141,13 @@ impl DiskTableWidget for Painter {
let first_n = graphemes
[..(*calculated_col_width as usize - 1)]
.concat();
- Cow::Owned(format!("{}…", first_n))
- } else {
- Cow::Borrowed(entry)
+ return Cow::Owned(format!("{}…", first_n));
}
- } else {
- Cow::Borrowed(entry)
}
- } else {
- Cow::Borrowed(entry)
}
- } else {
- Cow::Borrowed(entry)
}
+
+ Cow::Borrowed(entry)
},
);
@@ -159,7 +155,7 @@ impl DiskTableWidget for Painter {
});
// TODO: This seems to be bugged? The selected text style gets "stuck"? I think this gets fixed with tui 0.10?
- let (border_and_title_style, highlight_style) = if is_on_widget {
<