diff options
| author | Clement Tsang <34804052+ClementTsang@users.noreply.github.com> | 2021-04-22 23:43:12 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-22 23:43:12 -0400 |
| commit | f33bb42c5b234183117fa30d87b1fe6d9ab94d69 (patch) | |
| tree | 8fc79336c49b39f412e3f2c6e5a46c53aa920943 /assets | |
| parent | d9fd6be2ccad9d2eec888bd761cefc9ecbc16298 (diff) | |
feature: Add mount filtering, rework filter priority logic (#455)
This PR accomplishes two things:
1. This PR aims to add mount_filter to the config file. This allows a user to filter their disk widget entries by the mount name as well; this was particularly a problem in trying to address #431.
2. A slight rework of how the filter system works due to the need of being able to manage two potentially conflicting filter sources, since the disk widget will now potentially filter on both the disk name and the mount name.
In regards to the second point, the new behaviour is as such:
1. Is the entry allowed through any filter? That is, does it match an entry in a filter where is_list_ignored is false? If so, we always keep this entry.
2. Is the entry denied through any filter? That is, does it match an entry in a filter where is_list_ignored is true? If so, we always deny this entry.
3. Anything else is allowed.
This main (breaking) change is really the third point. This would mean that temp_filter and net_filter, when set to allow listed entries with is_list_ignored = false, are kinda... useless, as a whitelist in the scenario of being the only filter is kinda pointless. But hopefully this shouldn't be a problem...?
Diffstat (limited to 'assets')
| -rw-r--r-- | assets/disk_filter_post.png | bin | 15472 -> 0 bytes |
| -rw-r--r-- | assets/disk_filter_post2.png | bin | 15459 -> 0 bytes |
| -rw-r--r-- | assets/disk_filter_pre.png | bin | 23404 -> 0 bytes |
| -rw-r--r-- | assets/disk_name_filter.png | bin | 0 -> 15996 bytes |
| -rw-r--r-- | assets/disk_name_mount_filter.png | bin | 0 -> 25169 bytes |
| -rw-r--r-- | assets/disk_no_filter.png | bin | 0 -> 37441 bytes |
| -rw-r--r-- | assets/temp_filter_post.png | bin | 7655 -> 0 bytes |
| -rw-r--r-- | assets/temp_filter_post2.png | bin | 18247 -> 0 bytes |
| -rw-r--r-- | assets/temp_filter_post3.png | bin | 85155 -> 0 bytes |
| -rw-r--r-- | assets/temp_filter_pre.png | bin | 38769 -> 0 bytes |
10 files changed, 0 insertions, 0 deletions
diff --git a/assets/disk_filter_post.png b/assets/disk_filter_post.png Binary files differdeleted file mode 100644 index 012c3443..00000000 --- a/assets/disk_filter_post.png +++ /dev/null diff --git a/assets/disk_filter_post2.png b/assets/disk_filter_post2.png Binary files differdeleted file mode 100644 index 4b4a6706..00000000 --- a/assets/disk_filter_post2.png +++ /dev/null diff --git a/assets/disk_filter_pre.png b/assets/disk_filter_pre.png Binary files differdeleted file mode 100644 index a8e67e0b..00000000 --- a/assets/disk_filter_pre.png +++ /dev/null diff --git a/assets/disk_name_filter.png b/assets/disk_name_filter.png Binary files differnew file mode 100644 index 00000000..d36c1725 --- /dev/null +++ b/assets/disk_name_filter.png diff --git a/assets/disk_name_mount_filter.png b/assets/disk_name_mount_filter.png Binary files differnew file mode 100644 index 00000000..6c6ee769 --- /dev/null +++ b/assets/disk_name_mount_filter.png diff --git a/assets/disk_no_filter.png b/assets/disk_no_filter.png Binary files differnew file mode 100644 index 00000000..5c62f831 --- /dev/null +++ b/assets/disk_no_filter.png diff --git a/assets/temp_filter_post.png b/assets/temp_filter_post.png Binary files differdeleted file mode 100644 index d7358ec0..00000000 --- a/assets/temp_filter_post.png +++ /dev/null diff --git a/assets/temp_filter_post2.png b/assets/temp_filter_post2.png Binary files differdeleted file mode 100644 index 5eb27b97..00000000 --- a/assets/temp_filter_post2.png +++ /dev/null diff --git a/assets/temp_filter_post3.png b/assets/temp_filter_post3.png Binary files differdeleted file mode 100644 index f84886d1..00000000 --- a/assets/temp_filter_post3.png +++ /dev/null diff --git a/assets/temp_filter_pre.png b/assets/temp_filter_pre.png Binary files differdeleted file mode 100644 index 9445cd3e..00000000 --- a/assets/temp_filter_pre.png +++ /dev/null |
