diff options
| author | ClementTsang <cjhtsang@uwaterloo.ca> | 2020-05-04 18:55:03 -0400 |
|---|---|---|
| committer | ClementTsang <cjhtsang@uwaterloo.ca> | 2020-05-04 18:55:03 -0400 |
| commit | c22886bd324e8874e09fe65a9da2ec6b2a2d20b1 (patch) | |
| tree | fcd0a9f43a9b26028639cc8566e36154b927787a | |
| parent | 364049ee5f7a53fca8a3b442e7222aa1d0e79274 (diff) | |
docs: update contributing to mention that MSRV will fail cargo test
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ecf4b580..d85b28d2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -38,6 +38,8 @@ If you want to help contribute by submitting a PR, by all means, I'm open! In re - I develop primarily using _stable_ Rust. That is, whatever is the most up-to-date stable version you can get via running `rustup update stable`. However, as of writing, I do support a MSRV of 1.40.0. + - Note that `cargo test` will fail on anything lower than 1.43.0 due to it using a then-introduced env variable. + - I use both [clippy](https://github.com/rust-lang/rust-clippy) and [rustfmt](https://github.com/rust-lang/rustfmt) in development (with some settings, see [clippy.toml](./clippy.toml) and [rustfmt.toml](rustfmt.toml)). Note clippy must pass to pass CI. - You can check clippy using `cargo +nightly clippy`. |