diff options
| author | Clement Tsang <34804052+ClementTsang@users.noreply.github.com> | 2023-05-05 04:28:04 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-05 04:28:04 -0400 |
| commit | f237babb580bf5569e1b61021d9354bad69a19a9 (patch) | |
| tree | e7e47bc7b725d1e566586f54f1ae62992f5de75f /.github | |
| parent | 5548db6472bdc7648784f35df8ed20452d2dbf9d (diff) | |
ci: output a failure in the completion step if a previous step failed (#1128)
* ci: output a failure in the completion step if a previous step failed
* test
* okay now if I add failure
* yoink
* always
* use needs syntax
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/ci.yml | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f9d916b5..89522bd4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -141,7 +141,6 @@ jobs: needs: pre-job runs-on: ${{ matrix.info.os }} if: ${{ needs.pre-job.outputs.should_skip != 'true' }} - continue-on-error: true timeout-minutes: 20 strategy: fail-fast: false @@ -258,8 +257,16 @@ jobs: completion: name: "CI Pass Check" needs: [supported, other-check] + if: ${{ always() }} runs-on: "ubuntu-latest" steps: - name: CI Passed + if: ${{ needs.supported.result == 'success' && needs.other-check.result == 'success' }} run: | - echo "CI workflow completed." + echo "CI workflow completed successfully."; + + - name: CI Failed + if: ${{ needs.supported.result != 'success' || needs.other-check.result != 'success' }} + run: | + echo "CI workflow failed at some point."; + exit 1; |