| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
update CHANGES
|
|
|
|
Backport make constants for files cache mode more clear (#6724, 1.1)
|
|
* make constants for files cache mode more clear
Traditionally, DEFAULT_FILES_CACHE_MODE_UI and DEFAULT_FILES_CACHE_MODE
were - as the naming scheme implies - the same setting, one being the UI
representation as given to the --files-cache command line option and the
other being the same default value in the internal representation.
It happended that the actual value used in borg create always comes from
DEFAULT_FILES_CACHE_MODE_UI (because that does have the --files-cache
option) whereas for all other commands (that do not use the files cache) it
comes from DEFAULT_FILES_CACHE_MODE.
PR #5777 then abused this fact to implement the optimisation to skip loading
of the files cache in those other commands by changing the value of
DEFAULT_FILES_CACHE_MODE to disabled.
This however also changes the meaning of that variable and thus redesignates
it to something not matching the original naming anymore.
Anyone not aware of this change and the intention behind it looking at the
code would have a hard time figuring this out and be easily mislead.
This does away with the confusion making the code more maintainable by
renaming DEFAULT_FILES_CACHE_MODE to FILES_CACHE_MODE_DISABLED, making the
new intention of that internal default clear.
* make constant for files cache mode UI default match naming scheme
|
|
Backport Fix typos (#6688)
|
|
fix typos
Co-authored-by: Thomas Waldmann <tw@waldmann-edv.de>
|
|
mount -o versions: give clear error msg instead of crashing
|
|
it does not make sense to request versions view if you only
look at 1 archive, but the code shall not crash in that case
as it did, but give a clear error msg.
|
|
show_progress: add finished=true/false to archive_progress json
|
|
also:
- remove empty values from final json
- add test
|
|
Backport check that borg does not require pytest for normal usage (#6670, 1.1)
|
|
Backport mention BORG_FILES_CACHE_SUFFIX as alternative to BORG_FILES_CACHE_TTL (#6659)
|
|
also: move the note about this to the very top of the affected modules.
|
|
BORG_FILES_CACHE_TTL, fixes #5602
|
|
give a more helpful error msg for unsupported encrypted key format (1.1)
|
|
|
|
|
|
[1.1] Add a troubleshooting note to the FAQ
|
|
|
|
update CHANGES
|
|
FAQ: add a hint about --debug-topic=files_cache
|
|
|
|
|
|
info: fix authenticated mode repo to show "Encrypted: No", fixes #6462
|
|
|
|
do not load files cache for commands not using it, fixes #5673
|
|
fix transaction rollback: use files cache filename as found in txn.active
|
|
fixes #6353
|
|
|
|
(#6625)
diff: support presence change for blkdev, chrdev and fifo items
fixes #6483
|
|
remove stray punctuation from secure-erase message
|
|
better error msg for defect or unsupported repo configs, fixes #6566
|
|
|
|
|
|
virtualisation speed tips
|
|
|
|
load_key: no key is same as empty key, fixes #6441
|
|
when migrating from repokey to keyfile, we just store an empty key into the repo config,
because we do not have a "delete key" RPC api. thus, empty key means "there is no key".
here we fix load_key, so that it does not behave differently for no key and empty key:
in both cases, it just returns an empty value.
additionally, we strip the value we get from the config, so whitespace does not matter.
All callers now check for the repokey not being empty, otherwise RepoKeyNotFoundError
is raised.
|
|
docs: fix values of TAG bytes, fixes #6515
|
|
|
|
borg check improvements (1.1)
|
|
(docs) 1.1: Recommend umask for passphrase file perms
|
|
The previous sample for creating a ~/.borg-passphrase file creates it first and then chmod's it to 400 permissions. That's probably fine in practice, but means there's a tiny window where the passphrase file is sitting with default permissions (likely world readable, depending on the system umask).
It seems safer to first change the umask to remove all group & world bits (0077) _before_ creating the file. To be polite and avoid messing with the user's previous umask, we do this in a subshell. (Note that umask 0077 leads to a mode of 600 rather than the previous 400, because removing the owner write bit doesn't seem to buy much since the owner can just chmod the file anyway.)
|
|
this is similar to #4777.
borg check must not crash if an archive metadata block does not decrypt.
Instead, report the archive_id, remove the archive from the manifest and skip to the next archive.
|
|
borg check must not crash if an archive metadata chunk does not decrypt.
Instead, report the chunk and skip to the next one.
|
|
1.1 - Fix OpenBSD symlink mode test failure (#2055)
|
|
OpenBSD does not have `lchmod()` causing `os.lchmod` to be unavailable
on this platform. As a result ArchiverTestCase::test_basic_functionality
fails when run manually (#2055).
OpenBSD does have `fchmodat()`, which has a flag that makes it behave
like `lchmod()`. In Python this can be used via `os.chmod(path, mode,
follow_symlinks=False)`.
As of Python 3.3 `os.lchmod(path, mode)` is equivalent to
`os.chmod(path, mode, follow_symlinks=False)`. As such, switching to the
latter is preferred as it enables more platforms to do the right thing.
|
|
fix scp repo url parsing for ip v6 addrs, fixes #6526
|
