From 22c83ceb1a089c1af9a8d1707fc92d84388d465b Mon Sep 17 00:00:00 2001 From: Thomas Graf Date: Sun, 24 Aug 2014 20:44:53 +0200 Subject: proc: Fix leakage of fd if element lookup failed Fixes: CID 49002 Signed-off-by: Thomas Graf --- src/in_proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/in_proc.c b/src/in_proc.c index 245cd6b..1ba038f 100644 --- a/src/in_proc.c +++ b/src/in_proc.c @@ -151,7 +151,7 @@ static void proc_read(void) continue; if (!(e = element_lookup(grp, p, 0, NULL, ELEMENT_CREAT))) - return; + goto skip; if (e->e_flags & ELEMENT_FLAG_CREATED) { if (element_set_key_attr(e, "bytes", "packets") || @@ -171,7 +171,7 @@ static void proc_read(void) element_notify_update(e, NULL); element_lifesign(e, 1); } - +skip: fclose(fd); } -- cgit v1.2.3