summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRob Crowell <robccrowell@gmail.com>2022-01-25 16:13:05 -0800
committerRob Crowell <robccrowell@gmail.com>2022-01-25 16:24:04 -0800
commit2cab2d670aa011006f4322a59176ba3dbb6bb22b (patch)
treeaa4496f4ab9211a1394f696e61118d2536270e44
parent6457532274aeb51024cd9964bbfd2ca2a31dafc8 (diff)
Fix bug in StringQuery.string_match
-rw-r--r--beets/dbcore/query.py2
-rw-r--r--test/test_query.py4
2 files changed, 3 insertions, 3 deletions
diff --git a/beets/dbcore/query.py b/beets/dbcore/query.py
index c020deacb..b0c769790 100644
--- a/beets/dbcore/query.py
+++ b/beets/dbcore/query.py
@@ -191,7 +191,7 @@ class StringQuery(StringFieldQuery):
@classmethod
def string_match(cls, pattern, value):
- return pattern == value
+ return pattern.lower() == value.lower()
class SubstringQuery(StringFieldQuery):
diff --git a/test/test_query.py b/test/test_query.py
index 0b857ef7c..0be4b7d7f 100644
--- a/test/test_query.py
+++ b/test/test_query.py
@@ -395,12 +395,12 @@ class MatchTest(_common.TestCase):
def test_exact_match_nocase_positive(self):
q = dbcore.query.StringQuery('genre', 'the genre')
self.assertTrue(q.match(self.item))
+ q = dbcore.query.StringQuery('genre', 'THE GENRE')
+ self.assertTrue(q.match(self.item))
def test_exact_match_nocase_negative(self):
q = dbcore.query.StringQuery('genre', 'genre')
self.assertFalse(q.match(self.item))
- q = dbcore.query.StringQuery('genre', 'THE GENRE')
- self.assertFalse(q.match(self.item))
def test_year_match_positive(self):
q = dbcore.query.NumericQuery('year', '1')