diff options
| author | Adrian Sampson <adrian@radbox.org> | 2022-08-05 09:15:00 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-05 09:15:00 -0400 |
| commit | 6eec17c6610c06d21ef283cf84254669ef03c227 (patch) | |
| tree | 4951e56b9170a704d9206b79eefc9f39b39bf9a1 | |
| parent | 1dddcb8455fb6d06a3144e139d44a42a22da95c6 (diff) | |
| parent | 6803ef3b83b98fdc21e42df5cacd247e14be1b90 (diff) | |
Merge pull request #4433 from vicholp/master
Fix get item file in web plugin
| -rw-r--r-- | beetsplug/web/__init__.py | 2 | ||||
| -rw-r--r-- | docs/changelog.rst | 1 | ||||
| -rw-r--r-- | test/test_web.py | 10 |
3 files changed, 12 insertions, 1 deletions
diff --git a/beetsplug/web/__init__.py b/beetsplug/web/__init__.py index 63f7f92ad..b7baa93c1 100644 --- a/beetsplug/web/__init__.py +++ b/beetsplug/web/__init__.py @@ -324,7 +324,7 @@ def item_file(item_id): response = flask.send_file( item_path, as_attachment=True, - attachment_filename=safe_filename + download_name=safe_filename ) response.headers['Content-Length'] = os.path.getsize(item_path) return response diff --git a/docs/changelog.rst b/docs/changelog.rst index e6323393f..31861af24 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -92,6 +92,7 @@ Bug fixes: that casues a crash when ImportAdded plugin enabled. :bug:`4389` * :doc:`plugins/convert`: Fix a bug with the `wma` format alias. +* :doc:`/plugins/web`: Fix get file from item. For packagers: diff --git a/test/test_web.py b/test/test_web.py index 9a18b1dba..3c84b14ac 100644 --- a/test/test_web.py +++ b/test/test_web.py @@ -667,6 +667,16 @@ class WebPluginTest(_common.LibTestCase): # Remove the item self.lib.get_item(item_id).remove() + def test_get_item_file(self): + ipath = os.path.join(self.temp_dir, b'testfile2.mp3') + shutil.copy(os.path.join(_common.RSRC, b'full.mp3'), ipath) + self.assertTrue(os.path.exists(ipath)) + item_id = self.lib.add(Item.from_path(ipath)) + + response = self.client.get('/item/' + str(item_id) + '/file') + + self.assertEqual(response.status_code, 200) + def suite(): return unittest.TestLoader().loadTestsFromName(__name__) |