diff options
| author | Kelvin Zhang <zhangxp1998@gmail.com> | 2020-01-14 19:38:22 +0000 |
|---|---|---|
| committer | Kelvin Zhang <zhangxp1998@gmail.com> | 2020-01-14 19:38:22 +0000 |
| commit | a16d1e4fea64b61e2b477bab08bd5d136f2ec0d8 (patch) | |
| tree | 5b19ebd2ccc3fe5ce63b2b1a57ce501eefc95bfe | |
| parent | 5038987b2f58dd2afbb8f028e768cb20b3b33c03 (diff) | |
Address code review commnets
| -rw-r--r-- | src/network/sniffer.rs | 2 | ||||
| -rw-r--r-- | src/tests/fakes/fake_input.rs | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/network/sniffer.rs b/src/network/sniffer.rs index b7dcd54..4426438 100644 --- a/src/network/sniffer.rs +++ b/src/network/sniffer.rs @@ -95,7 +95,7 @@ impl Sniffer { pub fn next(&mut self) -> Option<Segment> { let bytes = self.network_frames.next().ok()?; // See https://github.com/libpnet/libpnet/blob/master/examples/packetdump.rs - let payload_offset = if self.network_interface.is_loopback() { + let payload_offset = if self.network_interface.is_loopback() && cfg!(target_os = "macos") { // The pnet code for BPF loopback adds a zero'd out Ethernet header 14 } else { diff --git a/src/tests/fakes/fake_input.rs b/src/tests/fakes/fake_input.rs index a06b617..3290ac2 100644 --- a/src/tests/fakes/fake_input.rs +++ b/src/tests/fakes/fake_input.rs @@ -151,7 +151,7 @@ pub fn get_interfaces() -> Vec<NetworkInterface> { index: 42, mac: None, ips: vec![IpNetwork::V4("10.0.0.2".parse().unwrap())], - // It's important that the IFF_LOOBACK bit is set to 0. + // It's important that the IFF_LOOPBACK bit is set to 0. // Otherwise sniffer will attempt to start parse packets // at offset 14 flags: 0, |