diff options
| author | Ian Smith <iansmith@honeycomb.io> | 2021-05-14 00:31:15 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-14 08:31:15 +0100 |
| commit | a127408e938ecd7060d7f81dec557bc5eaf06d75 (patch) | |
| tree | dcca46fefa9a10f301d2e2c7957a058627b6bfcc /src | |
| parent | f041d7fe4a46fe651ccc4f648584f4cf0aa30988 (diff) | |
run shellcheck (#97)
* run shellcheck
* Update .github/workflows/shellcheck.yml
Co-authored-by: Conrad Ludgate <oon@conradludgate.com>
* shellcheck fixes in which i am highly confident
* shellcheck fixes in which I am less confident - not executing this is fine, right?
* SC2155
In src/shell/atuin.bash line 1:
export ATUIN_SESSION=$(atuin uuid)
^-----------^ SC2155: Declare and assign separately to avoid masking return values.
* shellcheck doesn't support zsh, per https://github.com/koalaman/shellcheck/wiki/SC1071
* yaml fix
* gotta checkout our code, too
* yaml fix
* action spelling
* exclude .zsh
* Shellcheck doesn't support zsh, per
https://github.com/koalaman/shellcheck/wiki/SC1071, and the ignore: param
in ludeeus/action-shellcheck only supports _directories_, not _files_.
So instead, we manually add any error the shellcheck step finds in the
file to the above line ...
* comment all the ignores
* Update src/shell/atuin.bash
Co-authored-by: Ellie Huxtable <ellie@elliehuxtable.com>
* new zsh plugin shellcheck errors
* new zsh plugin shellcheck errors, pt 2
Co-authored-by: Conrad Ludgate <oon@conradludgate.com>
Co-authored-by: Ellie Huxtable <ellie@elliehuxtable.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/shell/atuin.bash | 3 | ||||
| -rw-r--r-- | src/shell/atuin.zsh | 8 |
2 files changed, 10 insertions, 1 deletions
diff --git a/src/shell/atuin.bash b/src/shell/atuin.bash index 038e4423..40bed30e 100644 --- a/src/shell/atuin.bash +++ b/src/shell/atuin.bash @@ -1,4 +1,5 @@ -export ATUIN_SESSION=$(atuin uuid) +ATUIN_SESSION=$(atuin uuid) +export ATUIN_SESSION _atuin_preexec() { id=$(atuin history start "$1") diff --git a/src/shell/atuin.zsh b/src/shell/atuin.zsh index 15f2492b..32cbe6a1 100644 --- a/src/shell/atuin.zsh +++ b/src/shell/atuin.zsh @@ -1,3 +1,11 @@ +# shellcheck disable=SC2034,SC2153,SC2086,SC2155 + +# Above line is because shellcheck doesn't support zsh, per +# https://github.com/koalaman/shellcheck/wiki/SC1071, and the ignore: param in +# ludeeus/action-shellcheck only supports _directories_, not _files_. So +# instead, we manually add any error the shellcheck step finds in the file to +# the above line ... + # Source this in your ~/.zshrc autoload -U add-zsh-hook |