summaryrefslogtreecommitdiffstats
path: root/font/src/ft
diff options
context:
space:
mode:
authorNathan Lilienthal <nathan@nixpulvis.com>2019-01-06 19:06:57 -0500
committerChristian Duerr <chrisduerr@users.noreply.github.com>2019-01-07 00:06:57 +0000
commit04707cbba630e3e4ad6b4200bef8ae7888c49e3b (patch)
treebd04f4964d4c4ad67cd565b38172b488172acfcc /font/src/ft
parentdfc30eeef5eb6df9f658e62875e5cde93173e37b (diff)
Normalize Log Message Strings
The general style for errors, warnings and info messages is to start with a capitalized letter and end without a period. The main exception is when dealing with nouns that are clearer with special case handling, e.g. "macOS failed to work" or "ioctl is borked".
Diffstat (limited to 'font/src/ft')
-rw-r--r--font/src/ft/fc/font_set.rs4
-rw-r--r--font/src/ft/mod.rs14
2 files changed, 9 insertions, 9 deletions
diff --git a/font/src/ft/fc/font_set.rs b/font/src/ft/fc/font_set.rs
index 6b63f439..4eccd487 100644
--- a/font/src/ft/fc/font_set.rs
+++ b/font/src/ft/fc/font_set.rs
@@ -63,7 +63,7 @@ impl<'a> IntoIterator for &'a FontSet {
(*self.as_ptr()).nfont as isize
};
- info!("num fonts = {}", num_fonts);
+ trace!("Number of fonts is {}", num_fonts);
Iter {
font_set: self.deref(),
@@ -81,7 +81,7 @@ impl<'a> IntoIterator for &'a FontSetRef {
(*self.as_ptr()).nfont as isize
};
- info!("num fonts = {}", num_fonts);
+ trace!("Number of fonts is {}", num_fonts);
Iter {
font_set: self,
diff --git a/font/src/ft/mod.rs b/font/src/ft/mod.rs
index 1d375295..6bcda2a1 100644
--- a/font/src/ft/mod.rs
+++ b/font/src/ft/mod.rs
@@ -117,7 +117,7 @@ impl ::Rasterize for FreeTypeRasterizer {
},
_ => {
// Fallback if font doesn't provide info about strikeout
- trace!("No strikeout data available for font, using fallback.");
+ trace!("Using fallback strikeout metrics");
let strikeout_position = height as f32 / 2. + descent;
(strikeout_position, underline_thickness)
},
@@ -267,7 +267,7 @@ impl FreeTypeRasterizer {
return Ok(Some(*key));
}
- trace!("got font path={:?}", path);
+ trace!("Got font path={:?}", path);
let ft_face = self.library.new_face(&path, index)?;
// Get available pixel sizes if font isn't scalable.
@@ -550,12 +550,12 @@ impl FreeTypeRasterizer {
// We've previously loaded this font, so don't
// load it again.
Some(&key) => {
- debug!("Hit for font {:?}; no need to load.", path);
+ debug!("Hit for font {:?}; no need to load", path);
Ok(key)
},
None => {
- debug!("Miss for font {:?}; loading now.", path);
+ debug!("Miss for font {:?}; loading now", path);
// Safe to unwrap the option since we've already checked for the path
// and index above.
let key = self.face_from_pattern(&pattern)?.unwrap();
@@ -604,9 +604,9 @@ impl ::std::error::Error for Error {
fn description(&self) -> &str {
match *self {
Error::FreeType(ref err) => err.description(),
- Error::MissingFont(ref _desc) => "couldn't find the requested font",
- Error::FontNotLoaded => "tried to operate on font that hasn't been loaded",
- Error::MissingSizeMetrics => "tried to get size metrics from a face without a size",
+ Error::MissingFont(ref _desc) => "Couldn't find the requested font",
+ Error::FontNotLoaded => "Tried to operate on font that hasn't been loaded",
+ Error::MissingSizeMetrics => "Tried to get size metrics from a face without a size",
}
}
}