Fix cursor position when scrolled into history

This fixes a regression introduced in 530de00, where the terminal cursor
would move up when the user scrolled up in the terminal history, rather
than staying in place.

Fixes #4784.

1 files changed, 9 insertions, 4 deletions

diff --git a/alacritty_terminal/src/term/mod.rs b/alacritty_terminal/src/term/mod.rs
index a898ecc4..b853ceba 100644
--- a/alacritty_terminal/src/term/mod.rs
+++ b/alacritty_terminal/src/term/mod.rs
@@ -1829,14 +1829,19 @@ impl RenderableCursor {
     fn new<T>(term: &Term<T>) -> Self {
         // Cursor position.
         let vi_mode = term.mode().contains(TermMode::VI);
-        let point = if vi_mode { term.vi_mode_cursor.point } else { term.grid().cursor.point };
+        let mut point = if vi_mode {
+            term.vi_mode_cursor.point
+        } else {
+            let mut point = term.grid.cursor.point;
+            point.line += term.grid.display_offset();
+            point
+        };
 
         // Cursor shape.
-        let absolute_line = term.screen_lines() - point.line - 1;
-        let display_offset = term.grid().display_offset();
         let shape = if !vi_mode
-            && (!term.mode().contains(TermMode::SHOW_CURSOR) || absolute_line.0 < display_offset)
+            && (!term.mode().contains(TermMode::SHOW_CURSOR) || point.line >= term.screen_lines())
         {
+            point.line = Line(0);
             CursorShape::Hidden
         } else {
             term.cursor_style().shape