diff options
| author | Colin Delahunty <72827203+colin99d@users.noreply.github.com> | 2023-08-18 07:51:37 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-18 14:51:37 +0000 |
| commit | 50c9d2c4ff3560588cb53a3f046fbaacf7ea42a9 (patch) | |
| tree | 56d00845982ccb4b1b6d0567e7786165dfa7bfd6 | |
| parent | b27bb59ef628c2d6cde36cf231a3a9580212e457 (diff) | |
Improve documentation (#5345)
* added fixes
* Added better error handling
* Added fixes
| -rw-r--r-- | openbb_terminal/stocks/fundamental_analysis/fa_controller.py | 5 | ||||
| -rw-r--r-- | openbb_terminal/stocks/fundamental_analysis/fmp_view.py | 5 | ||||
| -rw-r--r-- | openbb_terminal/terminal_controller.py | 7 |
3 files changed, 12 insertions, 5 deletions
diff --git a/openbb_terminal/stocks/fundamental_analysis/fa_controller.py b/openbb_terminal/stocks/fundamental_analysis/fa_controller.py index f8d6bb666f2..bd6c1e49763 100644 --- a/openbb_terminal/stocks/fundamental_analysis/fa_controller.py +++ b/openbb_terminal/stocks/fundamental_analysis/fa_controller.py @@ -325,8 +325,9 @@ class FundamentalAnalysisController(StockBaseController): formatter_class=argparse.ArgumentDefaultsHelpFormatter, prog="score", description=""" - Value investing tool based on Warren Buffett, Joseph Piotroski - and Benjamin Graham thoughts [Source: FMP] + Value investing based on Warren Buffett, Joseph Piotroski and Benjamin Graham thoughts [Source: FMP]. + Data is gathered from fmp and the scores are calculated using the valinvest library. The repository + For this library can be found here: https://github.com/astro30/valinvest """, ) parser.add_argument( diff --git a/openbb_terminal/stocks/fundamental_analysis/fmp_view.py b/openbb_terminal/stocks/fundamental_analysis/fmp_view.py index 8324b120834..9fa02d3c222 100644 --- a/openbb_terminal/stocks/fundamental_analysis/fmp_view.py +++ b/openbb_terminal/stocks/fundamental_analysis/fmp_view.py @@ -29,7 +29,10 @@ logger = logging.getLogger(__name__) def valinvest_score( symbol: str, years: int, export: str = "", sheet_name: Optional[str] = None ): - """Value investing tool based on Warren Buffett, Joseph Piotroski and Benjamin Graham thoughts [Source: FMP] + """ + Value investing tool based on Warren Buffett, Joseph Piotroski and Benjamin Graham thoughts [Source: FMP] + The data is gathered from fmp and the scores are calculated using the valinvest library. The repository + For this library can be found here: https://github.com/astro30/valinvest Parameters ---------- diff --git a/openbb_terminal/terminal_controller.py b/openbb_terminal/terminal_controller.py index 84453250a20..652c1f95b68 100644 --- a/openbb_terminal/terminal_controller.py +++ b/openbb_terminal/terminal_controller.py @@ -791,8 +791,11 @@ def terminal(jobs_cmds: Optional[List[str]] = None, test_mode=False): export_path = "" if jobs_cmds and "export" in jobs_cmds[0]: - export_path = jobs_cmds[0].split("/")[0].split(" ")[1] - jobs_cmds = ["/".join(jobs_cmds[0].split("/")[1:])] + commands = jobs_cmds[0].split("/") + first_split = commands[0].split(" ") + if len(first_split) > 1: + export_path = first_split[1] + jobs_cmds = ["/".join(commands[1:])] ret_code = 1 t_controller = TerminalController(jobs_cmds) |