summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormontezdesousa <79287829+montezdesousa@users.noreply.github.com>2023-09-20 10:31:44 +0100
committerGitHub <noreply@github.com>2023-09-20 10:31:44 +0100
commit46604019744fef0524e0008a92a20a9777fe325b (patch)
tree2e8b85a4b8f2ca7da4b01655adb8ae2d15dbb318
parentac5bcc5e9a7fd8fd87369828d10fb610cb2ec302 (diff)
Hotfix/tests passing (#5452)
* replace string dates with datetime in fetcher tests * lint
-rw-r--r--openbb_sdk/providers/cboe/openbb_cboe/models/european_index_historical.py8
-rw-r--r--openbb_sdk/providers/cboe/tests/test_cboe_fetchers.py8
-rw-r--r--openbb_sdk/providers/fmp/openbb_fmp/models/crypto_historical.py8
-rw-r--r--openbb_sdk/providers/fmp/openbb_fmp/models/dividend_calendar.py8
-rw-r--r--openbb_sdk/providers/fmp/openbb_fmp/models/forex_historical.py8
-rw-r--r--openbb_sdk/providers/fmp/openbb_fmp/models/major_indices_historical.py8
-rw-r--r--openbb_sdk/providers/fmp/openbb_fmp/models/stock_historical.py8
-rw-r--r--openbb_sdk/providers/fmp/openbb_fmp/models/stock_ownership.py8
-rw-r--r--openbb_sdk/providers/fmp/openbb_fmp/models/stock_splits.py10
-rw-r--r--openbb_sdk/providers/fmp/openbb_fmp/models/treasury_rates.py8
-rw-r--r--openbb_sdk/providers/fmp/tests/record/http/test_fmp_fetchers/test_fmp_stock_historical_fetcher.yaml4
-rw-r--r--openbb_sdk/providers/fmp/tests/test_fmp_fetchers.py34
-rw-r--r--openbb_sdk/providers/intrinio/openbb_intrinio/models/stock_historical.py8
-rw-r--r--openbb_sdk/providers/intrinio/tests/test_intrinio_fetchers.py8
-rw-r--r--openbb_sdk/providers/polygon/openbb_polygon/models/crypto_historical.py8
-rw-r--r--openbb_sdk/providers/polygon/openbb_polygon/models/forex_historical.py8
-rw-r--r--openbb_sdk/providers/polygon/openbb_polygon/models/forex_pairs.py4
-rw-r--r--openbb_sdk/providers/polygon/openbb_polygon/models/major_indices_historical.py9
-rw-r--r--openbb_sdk/providers/polygon/openbb_polygon/models/stock_historical.py8
-rw-r--r--openbb_sdk/providers/polygon/tests/test_polygon_fetchers.py28
-rw-r--r--openbb_sdk/providers/tests/utils/unit_test_generator.py13
-rw-r--r--openbb_sdk/providers/yfinance/openbb_yfinance/models/futures_curve.py7
-rw-r--r--openbb_sdk/providers/yfinance/tests/test_yfinance_fetchers.py24
-rw-r--r--tests/openbb_terminal/alternative/covid/test_covid_controller.py1
-rw-r--r--tests/openbb_terminal/alternative/oss/test_oss_controller.py1
-rw-r--r--tests/openbb_terminal/alternative/test_alt_controller.py1
-rw-r--r--tests/openbb_terminal/cryptocurrency/defi/test_defi_controller.py1
-rw-r--r--tests/openbb_terminal/cryptocurrency/discovery/test_discovery_controller.py1
-rw-r--r--tests/openbb_terminal/cryptocurrency/nft/test_nft_controller.py1
-rw-r--r--tests/openbb_terminal/cryptocurrency/onchain/test_onchain_controller.py1
-rw-r--r--tests/openbb_terminal/cryptocurrency/tools/test_tools_controller.py1
-rw-r--r--tests/openbb_terminal/futures/test_futures_controller.py1
-rw-r--r--tests/openbb_terminal/mutual_funds/test_mutual_fund_controller.py1
-rw-r--r--tests/openbb_terminal/portfolio/brokers/degiro/test_degiro_controller.py1
-rw-r--r--tests/openbb_terminal/portfolio/test_portfolio_controller.py1
-rw-r--r--tests/openbb_terminal/reports/test_reports_controller.py1
-rw-r--r--tests/openbb_terminal/stocks/discovery/test_disc_controller.py1
-rw-r--r--tests/openbb_terminal/stocks/fundamental_analysis/test_fa_controller.py1
-rw-r--r--tests/openbb_terminal/stocks/insider/test_openinsider_view.py1
39 files changed, 110 insertions, 151 deletions
diff --git a/openbb_sdk/providers/cboe/openbb_cboe/models/european_index_historical.py b/openbb_sdk/providers/cboe/openbb_cboe/models/european_index_historical.py
index ecbf15385d1..e437c2f9151 100644
--- a/openbb_sdk/providers/cboe/openbb_cboe/models/european_index_historical.py
+++ b/openbb_sdk/providers/cboe/openbb_cboe/models/european_index_historical.py
@@ -66,17 +66,9 @@ class CboeEuropeanIndexHistoricalFetcher(
transformed_params = params
if params.get("start_date") is None:
transformed_params["start_date"] = now - relativedelta(years=1)
- else:
- transformed_params["start_date"] = datetime.strptime(
- params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- params["end_date"], "%Y-%m-%d"
- ).date()
return CboeEuropeanIndexHistoricalQueryParams(**transformed_params)
diff --git a/openbb_sdk/providers/cboe/tests/test_cboe_fetchers.py b/openbb_sdk/providers/cboe/tests/test_cboe_fetchers.py
index 975a3dcd7d8..9517d151a41 100644
--- a/openbb_sdk/providers/cboe/tests/test_cboe_fetchers.py
+++ b/openbb_sdk/providers/cboe/tests/test_cboe_fetchers.py
@@ -1,3 +1,5 @@
+from datetime import date
+
import pytest
from openbb_cboe.models.available_indices import CboeAvailableIndicesFetcher
from openbb_cboe.models.european_index_constituents import (
@@ -99,7 +101,11 @@ def test_cboe_european_index_constituents_fetcher(credentials=test_credentials):
@pytest.mark.record_http
def test_cboe_european_index_historical_fetcher(credentials=test_credentials):
- params = {"symbol": "BUKBUS", "start_date": "2023-01-01", "end_date": "2023-01-10"}
+ params = {
+ "symbol": "BUKBUS",
+ "start_date": date(2023, 1, 1),
+ "end_date": date(2023, 1, 10),
+ }
fetcher = CboeEuropeanIndexHistoricalFetcher()
result = fetcher.test(params, credentials)
diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/crypto_historical.py b/openbb_sdk/providers/fmp/openbb_fmp/models/crypto_historical.py
index dd679c65bcb..5e3766b7dc7 100644
--- a/openbb_sdk/providers/fmp/openbb_fmp/models/crypto_historical.py
+++ b/openbb_sdk/providers/fmp/openbb_fmp/models/crypto_historical.py
@@ -72,17 +72,9 @@ class FMPCryptoHistoricalFetcher(
now = datetime.now().date()
if params.get("start_date") is None:
transformed_params["start_date"] = now - relativedelta(years=1)
- else:
- transformed_params["start_date"] = datetime.strptime(
- params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- params["end_date"], "%Y-%m-%d"
- ).date()
return FMPCryptoHistoricalQueryParams(**transformed_params)
diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/dividend_calendar.py b/openbb_sdk/providers/fmp/openbb_fmp/models/dividend_calendar.py
index 4dd3faef94d..d95f470159c 100644
--- a/openbb_sdk/providers/fmp/openbb_fmp/models/dividend_calendar.py
+++ b/openbb_sdk/providers/fmp/openbb_fmp/models/dividend_calendar.py
@@ -64,17 +64,9 @@ class FMPDividendCalendarFetcher(
now = datetime.now().date()
if params.get("start_date") is None:
transformed_params["start_date"] = now - relativedelta(years=1)
- else:
- transformed_params["start_date"] = datetime.strptime(
- params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- params["end_date"], "%Y-%m-%d"
- ).date()
return FMPDividendCalendarQueryParams(**transformed_params)
diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/forex_historical.py b/openbb_sdk/providers/fmp/openbb_fmp/models/forex_historical.py
index 1b51a97a874..eb88a751bd9 100644
--- a/openbb_sdk/providers/fmp/openbb_fmp/models/forex_historical.py
+++ b/openbb_sdk/providers/fmp/openbb_fmp/models/forex_historical.py
@@ -65,17 +65,9 @@ class FMPForexHistoricalFetcher(
now = datetime.now().date()
if params.get("start_date") is None:
transformed_params["start_date"] = now - relativedelta(years=1)
- else:
- transformed_params["start_date"] = datetime.strptime(
- params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- params["end_date"], "%Y-%m-%d"
- ).date()
return FMPForexHistoricalQueryParams(**transformed_params)
diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/major_indices_historical.py b/openbb_sdk/providers/fmp/openbb_fmp/models/major_indices_historical.py
index 5f1f9fbae15..033030b7b8d 100644
--- a/openbb_sdk/providers/fmp/openbb_fmp/models/major_indices_historical.py
+++ b/openbb_sdk/providers/fmp/openbb_fmp/models/major_indices_historical.py
@@ -81,17 +81,9 @@ class FMPMajorIndicesHistoricalFetcher(
now = datetime.now().date()
if params.get("start_date") is None:
transformed_params["start_date"] = now - relativedelta(years=1)
- else:
- transformed_params["start_date"] = datetime.strptime(
- params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- params["end_date"], "%Y-%m-%d"
- ).date()
return FMPMajorIndicesHistoricalQueryParams(**transformed_params)
diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/stock_historical.py b/openbb_sdk/providers/fmp/openbb_fmp/models/stock_historical.py
index c0a65529964..bd2ea81699b 100644
--- a/openbb_sdk/providers/fmp/openbb_fmp/models/stock_historical.py
+++ b/openbb_sdk/providers/fmp/openbb_fmp/models/stock_historical.py
@@ -74,17 +74,9 @@ class FMPStockHistoricalFetcher(
now = datetime.now().date()
if params.get("start_date") is None:
transformed_params["start_date"] = now - relativedelta(years=1)
- else:
- transformed_params["start_date"] = datetime.strptime(
- params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- params["end_date"], "%Y-%m-%d"
- ).date()
return FMPStockHistoricalQueryParams(**transformed_params)
diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/stock_ownership.py b/openbb_sdk/providers/fmp/openbb_fmp/models/stock_ownership.py
index 3c68b679c3b..13631f60380 100644
--- a/openbb_sdk/providers/fmp/openbb_fmp/models/stock_ownership.py
+++ b/openbb_sdk/providers/fmp/openbb_fmp/models/stock_ownership.py
@@ -48,13 +48,7 @@ class FMPStockOwnershipFetcher(
@staticmethod
def transform_query(params: Dict[str, Any]) -> FMPStockOwnershipQueryParams:
"""Transform the query params."""
- transform_params = params
-
- transform_params["date"] = datetime.strptime(
- transform_params["date"], "%Y-%m-%d"
- ).date()
-
- return FMPStockOwnershipQueryParams(**transform_params)
+ return FMPStockOwnershipQueryParams(**params)
@staticmethod
def extract_data(
diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/stock_splits.py b/openbb_sdk/providers/fmp/openbb_fmp/models/stock_splits.py
index 5db5cb806c1..5bf55f9a25d 100644
--- a/openbb_sdk/providers/fmp/openbb_fmp/models/stock_splits.py
+++ b/openbb_sdk/providers/fmp/openbb_fmp/models/stock_splits.py
@@ -1,7 +1,7 @@
"""FMP Stock Splits Calendar fetcher."""
-from datetime import date, datetime
+from datetime import date
from typing import Any, Dict, List, Optional
from dateutil.relativedelta import relativedelta
@@ -40,17 +40,9 @@ class FMPStockSplitCalendarFetcher(
now = date.today()
if params.get("start_date") is None:
transformed_params["start_date"] = now - relativedelta(years=1)
- else:
- transformed_params["start_date"] = datetime.strptime(
- params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- params["end_date"], "%Y-%m-%d"
- ).date()
return FMPStockSplitCalendarQueryParams(**transformed_params)
diff --git a/openbb_sdk/providers/fmp/openbb_fmp/models/treasury_rates.py b/openbb_sdk/providers/fmp/openbb_fmp/models/treasury_rates.py
index d19072c5434..fb7ca914a2c 100644
--- a/openbb_sdk/providers/fmp/openbb_fmp/models/treasury_rates.py
+++ b/openbb_sdk/providers/fmp/openbb_fmp/models/treasury_rates.py
@@ -65,17 +65,9 @@ class FMPTreasuryRatesFetcher(
now = datetime.now().date()
if params.get("start_date") is None:
transformed_params["start_date"] = now - timedelta(90)
- else:
- transformed_params["start_date"] = datetime.strptime(
- transformed_params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- transformed_params["end_date"], "%Y-%m-%d"
- ).date()
return FMPTreasuryRatesQueryParams(**transformed_params)
diff --git a/openbb_sdk/providers/fmp/tests/record/http/test_fmp_fetchers/test_fmp_stock_historical_fetcher.yaml b/openbb_sdk/providers/fmp/tests/record/http/test_fmp_fetchers/test_fmp_stock_historical_fetcher.yaml
index 5462d895aed..8dfbf3201e0 100644
--- a/openbb_sdk/providers/fmp/tests/record/http/test_fmp_fetchers/test_fmp_stock_historical_fetcher.yaml
+++ b/openbb_sdk/providers/fmp/tests/record/http/test_fmp_fetchers/test_fmp_stock_historical_fetcher.yaml
@@ -5,7 +5,7 @@ interactions:
Accept:
- '*/*'
Accept-Encoding:
- - gzip, deflate, br
+ - gzip, deflate
Connection:
- keep-alive
method: GET
@@ -42,7 +42,7 @@ interactions:
Content-Type:
- application/json; charset=utf-8
Date:
- - Tue, 19 Sep 2023 11:13:19 GMT
+ - Wed, 20 Sep 2023 08:44:05 GMT
ETag:
- W/"890-71zThPvex5A4Sl4GSuy+Npc+m7c"
Server:
diff --git a/openbb_sdk/providers/fmp/tests/test_fmp_fetchers.py b/openbb_sdk/providers/fmp/tests/test_fmp_fetchers.py
index 0e1f9f5b6f8..5e4d6d4dd5c 100644
--- a/openbb_sdk/providers/fmp/tests/test_fmp_fetchers.py
+++ b/openbb_sdk/providers/fmp/tests/test_fmp_fetchers.py
@@ -1,3 +1,5 @@
+from datetime import date
+
import pytest
from openbb_core.app.service.user_service import UserService
from openbb_fmp.models.analyst_estimates import FMPAnalystEstimatesFetcher
@@ -60,7 +62,11 @@ def vcr_config():
@pytest.mark.record_http
def test_fmp_crypto_historical_fetcher(credentials=test_credentials):
- params = {"symbol": "BTCUSD", "start_date": "2023-01-01", "end_date": "2023-01-10"}
+ params = {
+ "symbol": "BTCUSD",
+ "start_date": date(2023, 1, 1),
+ "end_date": date(2023, 1, 10),
+ }
fetcher = FMPCryptoHistoricalFetcher()
result = fetcher.test(params, credentials)
@@ -69,7 +75,11 @@ def test_fmp_crypto_historical_fetcher(credentials=test_credentials):
@pytest.mark.record_http
def test_fmp_forex_historical_fetcher(credentials=test_credentials):
- params = {"symbol": "EURUSD", "start_date": "2023-01-01", "end_date": "2023-01-10"}
+ params = {
+ "symbol": "EURUSD",
+ "start_date": date(2023, 1, 1),
+ "end_date": date(2023, 1, 10),
+ }
fetcher = FMPForexHistoricalFetcher()
result = fetcher.test(params, credentials)
@@ -78,7 +88,11 @@ def test_fmp_forex_historical_fetcher(credentials=test_credentials):
@pytest.mark.record_http
def test_fmp_major_indices_historical_fetcher(credentials=test_credentials):
- params = {"symbol": "^DJI", "start_date": "2023-01-01", "end_date": "2023-01-10"}
+ params = {
+ "symbol": "^DJI",
+ "start_date": date(2023, 1, 1),
+ "end_date": date(2023, 1, 10),
+ }
fetcher = FMPMajorIndicesHistoricalFetcher()
result = fetcher.test(params, credentials)
@@ -87,7 +101,11 @@ def test_fmp_major_indices_historical_fetcher(credentials=test_credentials):
@pytest.mark.record_http
def test_fmp_stock_historical_fetcher(credentials=test_credentials):
- params = {"symbol": "AAPL", "start_date": "2023-01-01", "end_date": "2023-01-10"}
+ params = {
+ "symbol": "AAPL",
+ "start_date": date(2023, 1, 1),
+ "end_date": date(2023, 1, 10),
+ }
fetcher = FMPStockHistoricalFetcher()
result = fetcher.test(params, credentials)
@@ -240,7 +258,7 @@ def test_fmp_stock_insider_trading_fetcher(credentials=test_credentials):
@pytest.mark.record_http
def test_fmp_stock_ownership_fetcher(credentials=test_credentials):
- params = {"symbol": "AAPL", "date": "2022-12-31"}
+ params = {"symbol": "AAPL", "date": date(2022, 12, 31)}
fetcher = FMPStockOwnershipFetcher()
result = fetcher.test(params, credentials)
@@ -303,7 +321,7 @@ def test_fmp_historical_stock_splits_fetcher(credentials=test_credentials):
@pytest.mark.record_http
def test_fmp_stock_split_calendar_fetcher(credentials=test_credentials):
- params = {"start_date": "2023-01-01", "end_date": "2023-01-10"}
+ params = {"start_date": date(2023, 1, 1), "end_date": date(2023, 1, 10)}
fetcher = FMPStockSplitCalendarFetcher()
result = fetcher.test(params, credentials)
@@ -339,7 +357,7 @@ def test_fmpsec_filings_fetcher(credentials=test_credentials):
@pytest.mark.record_http
def test_fmp_treasury_rates_fetcher(credentials=test_credentials):
- params = {"start_date": "2023-01-01", "end_date": "2023-05-10"}
+ params = {"start_date": date(2023, 1, 1), "end_date": date(2023, 5, 10)}
fetcher = FMPTreasuryRatesFetcher()
result = fetcher.test(params, credentials)
@@ -411,7 +429,7 @@ def test_fmp_major_indices_constituents_fetcher(credentials=test_credentials):
@pytest.mark.record_http
def test_fmp_dividend_calendar_fetcher(credentials=test_credentials):
- params = {"start_date": "2023-01-01", "end_date": "2023-05-10"}
+ params = {"start_date": date(2023, 1, 1), "end_date": date(2023, 5, 10)}
fetcher = FMPDividendCalendarFetcher()
result = fetcher.test(params, credentials)
diff --git a/openbb_sdk/providers/intrinio/openbb_intrinio/models/stock_historical.py b/openbb_sdk/providers/intrinio/openbb_intrinio/models/stock_historical.py
index c77c37af017..8207b78dbc8 100644
--- a/openbb_sdk/providers/intrinio/openbb_intrinio/models/stock_historical.py
+++ b/openbb_sdk/providers/intrinio/openbb_intrinio/models/stock_historical.py
@@ -102,17 +102,9 @@ class IntrinioStockHistoricalFetcher(
now = datetime.now().date()
if params.get("start_date") is None:
transformed_params["start_date"] = now - relativedelta(years=1)
- else:
- transformed_params["start_date"] = datetime.strptime(
- params["start_date"], "%Y-%m-%d"
- ).date()
if params.get("end_date") is None:
transformed_params["end_date"] = now
- else:
- transformed_params["end_date"] = datetime.strptime(
- params["end_date"], "%Y-%m-%d"
- ).date()
if params.get("start_time") is None:
transformed_params["start_time"] = time(0, 0, 0)
diff --git a/openbb_sdk/providers/