diff options
author | Diogo Sousa <montezdesousa@gmail.com> | 2024-05-21 23:10:54 +0100 |
---|---|---|
committer | Diogo Sousa <montezdesousa@gmail.com> | 2024-05-21 23:10:54 +0100 |
commit | faf11803d11daddddd7aa7ed081c3ff9a15624ef (patch) | |
tree | e04eefef5528c247599c61e1ff4091d844e9915a | |
parent | 8282406ef15758ba142b6ccd78a5121edb0f3efd (diff) |
fix: unittests
4 files changed, 10 insertions, 59 deletions
diff --git a/openbb_platform/core/tests/app/model/test_defaults.py b/openbb_platform/core/tests/app/model/test_defaults.py index e4a3df6dd21..9b9e91714ad 100644 --- a/openbb_platform/core/tests/app/model/test_defaults.py +++ b/openbb_platform/core/tests/app/model/test_defaults.py @@ -5,14 +5,11 @@ from openbb_core.app.model.defaults import Defaults def test_defaults(): """Test the Defaults class.""" - cc = Defaults(routes={"test": {"test": "test"}}) + cc = Defaults(commands={"/equity/price": {"provider": "test"}}) assert isinstance(cc, Defaults) - assert cc.routes == {"test": {"test": "test"}} + assert cc.commands == {"equity.price": {"provider": "test"}} def test_fields(): """Test the Defaults fields.""" - fields = Defaults.model_fields - fields_keys = fields.keys() - - assert "routes" in fields_keys + assert "commands" in Defaults.model_fields diff --git a/openbb_platform/core/tests/app/test_command_runner.py b/openbb_platform/core/tests/app/test_command_runner.py index d56acfca82c..41205ca75e5 100644 --- a/openbb_platform/core/tests/app/test_command_runner.py +++ b/openbb_platform/core/tests/app/test_command_runner.py @@ -177,52 +177,6 @@ def test_parameters_builder_update_command_context( assert result["cc"].user_settings == user_settings -@pytest.mark.parametrize( - "command_coverage, route, kwargs, route_default, expected_result", - [ - ( - {"route1": ["choice1", "choice2"]}, - "route1", - {"provider_choices": {"provider": None}}, - None, - {"provider_choices": {"provider": None}}, - ), - ( - {"route1": ["choice1", "choice2"]}, - "route1", - {"provider_choices": {"provider": ["choice1", "choice2"]}}, - {"provider": "choice1"}, - {"provider_choices": {"provider": ["choice1", "choice2"]}}, - ), - ( - {}, - "route2", - {}, - {"provider": "default_provider"}, - {}, - ), - ( - {}, - "route3", - {"provider_choices": {"provider": "existing_provider"}}, - None, - {"provider_choices": {"provider": "existing_provider"}}, - ), - ], -) -def test_parameters_builder_update_provider_choices( - command_coverage, route, kwargs, route_default, expected_result -): - """Test update_provider_choices.""" - with patch("openbb_core.app.command_runner.ProviderInterface") as mock_pi: - mock_pi.available_providers = ["provider1", "provider2"] - result = ParametersBuilder.update_provider_choices( - mock_func, command_coverage, route, kwargs, route_default - ) - - assert result == expected_result - - def test_parameters_builder_validate_kwargs(mock_func): """Test validate_kwargs.""" # TODO: add more test cases with @pytest.mark.parametrize @@ -253,7 +207,7 @@ def test_parameters_builder__warn_kwargs(extra_params, base, expect): """Test _warn_kwargs.""" @dataclass - class SomeModel(base): + class SomeModel(base): # type: ignore[misc,valid-type] """SomeModel""" exists: QueryParam = Query(...) @@ -276,7 +230,7 @@ def test_parameters_builder_build(mock_func, execution_context): """Test build.""" # TODO: add more test cases with @pytest.mark.parametrize - with patch("openbb_core.app.command_runner.ProviderInterface") as mock_pi: + with patch("openbb_core.app.provider_interface.ProviderInterface") as mock_pi: mock_pi.available_providers = ["provider1", "provider2"] result = ParametersBuilder.build( @@ -284,11 +238,10 @@ def test_parameters_builder_build(mock_func, execution_context): kwargs={ "c": 3, "d": "4", - "provider_choices": {"provider": ["provider1", "provider2"]}, + "provider_choices": {"provider": "provider1"}, }, func=mock_func, execution_context=execution_context, - route="mock/route", ) assert result == { @@ -296,7 +249,7 @@ def test_parameters_builder_build(mock_func, execution_context): "b": 2, "c": 3.0, "d": 4, - "provider_choices": {"provider": ["provider1", "provider2"]}, + "provider_choices": {"provider": "provider1"}, } diff --git a/openbb_platform/core/tests/app/test_provider_interface.py b/openbb_platform/core/tests/app/test_provider_interface.py index 395ee0dbeb9..4062c52172c 100644 --- a/openbb_platform/core/tests/app/test_provider_interface.py +++ b/openbb_platform/core/tests/app/test_provider_interface.py @@ -31,7 +31,7 @@ def test_map(provider_interface): def test_credentials(provider_interface): """Test required credentials.""" credentials = provider_interface.credentials - assert isinstance(credentials, list) + assert isinstance(credentials, dict) assert len(credentials) > 0 diff --git a/openbb_platform/core/tests/provider/test_registry_map.py b/openbb_platform/core/tests/provider/test_registry_map.py index 67c905a8821..052a4c735d4 100644 --- a/openbb_platform/core/tests/provider/test_registry_map.py +++ b/openbb_platform/core/tests/provider/test_registry_map.py @@ -16,7 +16,8 @@ def test_get_credentials(load_registry_map): """Test if the _get_credentials method behaves as expected.""" required_creds = load_registry_map.credentials - assert "fmp_api_key" in required_creds + assert "fmp" in required_creds + assert required_creds["fmp"] == ["fmp_api_key"] def test_get_available_providers(load_registry_map): |