diff options
author | James Maslek <jmaslek11@gmail.com> | 2023-09-28 12:43:30 -0400 |
---|---|---|
committer | James Maslek <jmaslek11@gmail.com> | 2023-09-28 12:43:30 -0400 |
commit | 038484d1f1c4eda25a84f50ac1be0468adb52923 (patch) | |
tree | 0d869b7da24ff79495c72d9a9b93b700eff6a12d | |
parent | 4eb8ad027095993cdb16e3c367418e2a6b8c79cf (diff) | |
parent | 40ae229494fce65fe638b32d89f896beee9bbb88 (diff) |
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTerminal into develop
-rw-r--r-- | openbb_terminal/routine_functions.py | 2 | ||||
-rw-r--r-- | reviewpad.yaml | 98 |
2 files changed, 53 insertions, 47 deletions
diff --git a/openbb_terminal/routine_functions.py b/openbb_terminal/routine_functions.py index f29cb58c1d4..5b2098b0612 100644 --- a/openbb_terminal/routine_functions.py +++ b/openbb_terminal/routine_functions.py @@ -411,7 +411,7 @@ def parse_openbb_script( # noqa: PLR0911,PLR0912 for line in lines_with_vars_replaced: # Found 'foreach' header associated with loop match = re.search( - r"foreach \$\$([A-Za-z\_]+) in ([A-Za-z0-9,-]+)", line, re.IGNORECASE + r"foreach \$\$([A-Za-z\_]+) in ([A-Za-z0-9,-.]+)", line, re.IGNORECASE ) if match: varname = match.group(1) diff --git a/reviewpad.yaml b/reviewpad.yaml index f9f489b95fc..dba44e70b30 100644 --- a/reviewpad.yaml +++ b/reviewpad.yaml @@ -4,61 +4,67 @@ groups: rules: - name: changes-requirements - spec: $hasFileName("requirements.txt") && $hasFileName("requirements-full.txt") + spec: $containsFileName("requirements.txt") && $containsFileName("requirements-full.txt") + - name: should-run-reviewpad + spec: '!$isElementOf("reviewpad-ignore", $getLabels())' workflows: - name: label-pull-request-with-size description: Label pull request based on the number of lines changed - always-run: true - if: - # Calculate size while ignoring patterns in the "ignored-patterns" group - # For more details about size follow https://docs.reviewpad.com/guides/built-ins/#size - - rule: $size($group("ignored-patterns")) <= 100 - extra-actions: + run: + - if: $rule("should-run-reviewpad") + then: + # Calculate size while ignoring patterns in the "ignored-patterns" group + # For more details about size follow https://docs.reviewpad.com/guides/built-ins/#size + - if: $getSize($group("ignored-patterns")) <= 100 + then: - $removeLabels(["feat S", "feat M", "feat L", "feat XL"]) - $addLabel("feat XS") - - rule: $size($group("ignored-patterns")) > 100 && $size($group("ignored-patterns")) <= 300 - extra-actions: - - $removeLabels(["feat XS", "feat M", "feat L", "feat XL"]) - - $addLabel("feat S") - - rule: $size($group("ignored-patterns")) > 300 && $size($group("ignored-patterns")) <= 900 - extra-actions: - - $removeLabels(["feat XS", "feat S", "feat L", "feat XL"]) - - $addLabel("feat M") - - rule: $size($group("ignored-patterns")) > 900 && $size($group("ignored-patterns")) <= 1800 - extra-actions: - - $removeLabels(["feat XS", "feat S", "feat M", "feat XL"]) - - $addLabel("feat L") - - rule: $size($group("ignored-patterns")) > 1800 - extra-actions: - - $removeLabels(["feat XS", "feat S", "feat M", "feat L"]) - - $addLabel("feat XL") + - if: $getSize($group("ignored-patterns")) > 100 && $getSize($group("ignored-patterns")) <= 300 + then: + - $removeLabels(["feat XS", "feat M", "feat L", "feat XL"]) + - $addLabel("feat S") + - if: $getSize($group("ignored-patterns")) > 300 && $getSize($group("ignored-patterns")) <= 900 + then: + - $removeLabels(["feat XS", "feat S", "feat L", "feat XL"]) + - $addLabel("feat M") + - if: $getSize($group("ignored-patterns")) > 900 && $getSize($group("ignored-patterns")) <= 1800 + then: + - $removeLabels(["feat XS", "feat S", "feat M", "feat XL"]) + - $addLabel("feat L") + - if: $getSize($group("ignored-patterns")) > 1800 + then: + - $removeLabels(["feat XS", "feat S", "feat M", "feat L"]) + - $addLabel("feat XL") - name: sanity description: Verify pull request sanity - always-run: true - if: - - rule: $hasFileExtensions([".py"]) && $size() > 1000 - extra-actions: - - $fail("This PR is very large and hard to review. Please split PR into multiple") - - rule: $hasBinaryFile() - extra-actions: - - $fail("Images are not allowed in the repository, please remove images from the PR") + run: + - if: $rule("should-run-reviewpad") + then: + - if: $containsOnlyFileExtensions([".py"]) && $getSize() > 1000 + then: + - $failCheckStatus("This PR is very large and hard to review. Please split PR into multiple") + - if: $containsBinaryFiles() + then: + - $failCheckStatus("Images are not allowed in the repository, please remove images from the PR") - name: dependencies description: Verify pull request dependency changes - always-run: true - if: - - rule: '!$isDraft() && $hasFileName("poetry.lock") && !$rule("changes-requirements")' - extra-actions: - - $review("REQUEST_CHANGES", "The `poetry.lock` file has been changed. Please update both `requirements.txt` and `requirements-full.txt` files") - - rule: '!$isDraft() && $hasFileName("pyproject.toml") && !$rule("changes-requirements")' - extra-actions: - - $warn("The `pyproject.toml` file has been changed. Please make sure that the files `requirements.txt` and `requirements-full.txt` do not need to be updated") + run: + - if: $rule("should-run-reviewpad") + then: + - if: '!$isDraft() && $containsFileName("poetry.lock") && !$rule("changes-requirements")' + then: + - $review("REQUEST_CHANGES", "The `poetry.lock` file has been changed. Please update both `requirements.txt` and `requirements-full.txt` files") + - if: '!$isDraft() && $containsFileName("pyproject.toml") && !$rule("changes-requirements")' + then: + - $reportWarning("The `pyproject.toml` file has been changed. Please make sure that the files `requirements.txt` and `requirements-full.txt` do not need to be updated") - name: EOF description: Verify files EOF - always-run: true - if: - # By default, Reviewpad splits each file in the patch using the line feed character (\n or LF). - # This means that if a file has a carriage return character (\r) at the end, it indicates that the file has CRLF line endings instead. - - rule: $hasCodePattern("\r$$") - extra-actions: - - $warn("It looks like you have files with `CRLF` line endings. Please make sure that all files have `LF` line endings") + run: + - if: $rule("should-run-reviewpad") + then: + # By default, Reviewpad splits each file in the patch using the line feed character (\n or LF). + # This means that if a file has a carriage return character (\r) at the end, it indicates that the file has CRLF line endings instead. + - if: $containsCodePattern("\r$$") + then: + - $reportWarning("It looks like you have files with `CRLF` line endings. Please make sure that all files have `LF` line endings") |