diff options
| author | Danglewood <85772166+deeleeramone@users.noreply.github.com> | 2024-02-28 00:51:40 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-28 08:51:40 +0000 |
| commit | d46e96053fd88a7d9df31047da29529c9fac2172 (patch) | |
| tree | cbc9183a8b1effe610edc689b0c6bf32dccc9f34 | |
| parent | 2332725834ccba3d0079669c1e83b5635fd8a986 (diff) | |
fix intraday check in charting ta_class (#6119)
Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>
3 files changed, 8 insertions, 2 deletions
diff --git a/openbb_platform/core/integration/test_obbject.py b/openbb_platform/core/integration/test_obbject.py index a76d5d644fb..735dc520969 100644 --- a/openbb_platform/core/integration/test_obbject.py +++ b/openbb_platform/core/integration/test_obbject.py @@ -75,7 +75,7 @@ def test_to_chart(obb): """Test obbject to chart.""" res = obb.equity.price.historical("AAPL", provider="fmp") - res.charting.to_chart() + res.charting.to_chart(render=False) assert isinstance(res.chart.fig, OpenBBFigure) diff --git a/openbb_platform/obbject_extensions/charting/openbb_charting/__init__.py b/openbb_platform/obbject_extensions/charting/openbb_charting/__init__.py index 68391476ac0..ebf29aa54f7 100644 --- a/openbb_platform/obbject_extensions/charting/openbb_charting/__init__.py +++ b/openbb_platform/obbject_extensions/charting/openbb_charting/__init__.py @@ -178,7 +178,7 @@ class Charting: index = ( data.index.name if has_data and isinstance(data, (pd.DataFrame, pd.Series)) - else "" + else None ) data_as_df: pd.DataFrame = ( basemodel_to_df(convert_to_basemodel(data), index=index) diff --git a/openbb_platform/obbject_extensions/charting/openbb_charting/core/plotly_ta/ta_class.py b/openbb_platform/obbject_extensions/charting/openbb_charting/core/plotly_ta/ta_class.py index eba0a599445..ebe12307ed3 100644 --- a/openbb_platform/obbject_extensions/charting/openbb_charting/core/plotly_ta/ta_class.py +++ b/openbb_platform/obbject_extensions/charting/openbb_charting/core/plotly_ta/ta_class.py @@ -182,6 +182,12 @@ class PlotlyTA(PltTA): if not isinstance(indicators, ChartIndicators): indicators = ChartIndicators.from_dict(indicators or dict(dict())) + # Apply to_datetime to the index in a way that handles daylight savings. + df_stock.loc[:, "date"] = df_stock.index # type: ignore + df_stock["date"] = df_stock["date"].apply(pd.to_datetime) + df_stock.index = df_stock["date"] # type: ignore + df_stock.drop(columns=["date"], inplace=True) + self.indicators = indicators self.intraday = df_stock.index[-2].time() != df_stock.index[-1].time() self.df_stock = df_stock.sort_index(ascending=True) |