diff options
author | Matthias Beyer <matthias.beyer@ifm.com> | 2022-02-02 11:29:55 +0100 |
---|---|---|
committer | Matthias Beyer <matthias.beyer@ifm.com> | 2022-02-15 14:26:18 +0100 |
commit | 1f2dd2f9e7c2798cf0c34223ed5761d532b38112 (patch) | |
tree | 7388f4ab9fac764b7c276a048c5c81203069791d | |
parent | 4380da12964296a9e1b8d6050111098e85c9422c (diff) |
Remove new() constructor in favour of Default impl
This fixes clippy lint `clippy::new_without_default`
Signed-off-by: Matthias Beyer <matthias.beyer@ifm.com>
-rw-r--r-- | crates/core/thin_edge_json/src/builder.rs | 9 | ||||
-rw-r--r-- | crates/core/thin_edge_json/src/parser.rs | 4 | ||||
-rw-r--r-- | crates/core/thin_edge_json/tests/test_suite.rs | 2 |
3 files changed, 4 insertions, 11 deletions
diff --git a/crates/core/thin_edge_json/src/builder.rs b/crates/core/thin_edge_json/src/builder.rs index cb4b9ee6..8c0bc740 100644 --- a/crates/core/thin_edge_json/src/builder.rs +++ b/crates/core/thin_edge_json/src/builder.rs @@ -3,6 +3,7 @@ use time::OffsetDateTime; use crate::{data::*, measurement::*}; /// A `MeasurementVisitor` that builds up `ThinEdgeJson`. +#[derive(Default)] pub struct ThinEdgeJsonBuilder { timestamp: Option<OffsetDateTime>, inside_group: Option<MultiValueMeasurement>, @@ -10,14 +11,6 @@ pub struct ThinEdgeJsonBuilder { } impl ThinEdgeJsonBuilder { - pub fn new() -> Self { - Self { - timestamp: None, - inside_group: None, - measurements: Vec::new(), - } - } - pub fn done(self) -> Result<ThinEdgeJson, ThinEdgeJsonBuilderError> { if self.inside_group.is_some() { return Err(ThinEdgeJsonBuilderError::UnexpectedOpenGroup); diff --git a/crates/core/thin_edge_json/src/parser.rs b/crates/core/thin_edge_json/src/parser.rs index 080345ed..297be75e 100644 --- a/crates/core/thin_edge_json/src/parser.rs +++ b/crates/core/thin_edge_json/src/parser.rs @@ -317,7 +317,7 @@ mod tests { "escaped\\": 123.0 }"#; - let mut builder = ThinEdgeJsonBuilder::new(); + let mut builder = ThinEdgeJsonBuilder::default(); let () = parse_str(input, &mut builder)?; @@ -350,7 +350,7 @@ mod tests { let input = "{\n\"time\" : null\n}"; - let mut builder = ThinEdgeJsonBuilder::new(); + let mut builder = ThinEdgeJsonBuilder::default(); let res = parse_str(input, &mut builder); diff --git a/crates/core/thin_edge_json/tests/test_suite.rs b/crates/core/thin_edge_json/tests/test_suite.rs index 94482192..51889ca9 100644 --- a/crates/core/thin_edge_json/tests/test_suite.rs +++ b/crates/core/thin_edge_json/tests/test_suite.rs @@ -10,7 +10,7 @@ fn it_rejects_invalid_thin_edge_json() -> anyhow::Result<()> { println!("Fixture: {:?}", fixture.path()); let res: anyhow::Result<_> = { - let mut builder = thin_edge_json::builder::ThinEdgeJsonBuilder::new(); + let mut builder = thin_edge_json::builder::ThinEdgeJsonBuilder::default(); thin_edge_json::parser::parse_str(&input, &mut builder) .map_err(Into::into) .and_then(|_| builder.done().map_err(Into::into)) |