From 8e5918fb8eb90289a0c89f6a4c6d623ecf49cf43 Mon Sep 17 00:00:00 2001 From: Neil Horman Date: Wed, 10 Apr 2024 08:28:43 -0400 Subject: Fix duplicate mutex allocation in threads_win.c Creating an rcu lock does a double allocation of the underlying mutex. Not sure how asan didn't catch this, but we clearly have a duplicate line here Fixes #24085 Reviewed-by: Richard Levitte Reviewed-by: Kurt Roeckx Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/24086) --- crypto/threads_win.c | 1 - 1 file changed, 1 deletion(-) diff --git a/crypto/threads_win.c b/crypto/threads_win.c index 8428869963..9aec5e972f 100644 --- a/crypto/threads_win.c +++ b/crypto/threads_win.c @@ -158,7 +158,6 @@ CRYPTO_RCU_LOCK *ossl_rcu_lock_new(int num_writers) new->prior_signal = ossl_crypto_condvar_new(); new->alloc_lock = ossl_crypto_mutex_new(); new->prior_lock = ossl_crypto_mutex_new(); - new->write_lock = ossl_crypto_mutex_new(); new->qp_group = allocate_new_qp_group(new, num_writers + 1); if (new->qp_group == NULL || new->alloc_signal == NULL -- cgit v1.2.3