diff options
author | Tomas Mraz <tomas@openssl.org> | 2023-07-25 15:56:53 +0200 |
---|---|---|
committer | Matt Caswell <matt@openssl.org> | 2023-07-31 14:30:37 +0100 |
commit | 34d0f5cb93680a5286d1eb59125631ec8fd6dc81 (patch) | |
tree | c48b51307ba36434bc5ffbca1bf225579d09a7df | |
parent | 91ddeba0f2269b017dc06c46c993a788974b1aa5 (diff) |
dhtest.c: Add test of DH_check() with q = p + 1
This must fail with DH_CHECK_INVALID_Q_VALUE and
with DH_CHECK_Q_NOT_PRIME unset.
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21551)
-rw-r--r-- | test/dhtest.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/test/dhtest.c b/test/dhtest.c index 00b3c47101..d7e10ebda9 100644 --- a/test/dhtest.c +++ b/test/dhtest.c @@ -123,6 +123,15 @@ static int dh_test(void) /* check whether the public key was calculated correctly */ TEST_uint_eq(BN_get_word(pub_key2), 3331L); + if (!TEST_ptr(BN_copy(q, p)) || !TEST_true(BN_add(q, q, BN_value_one()))) + goto err3; + + if (!TEST_true(DH_check(dh, &i))) + goto err3; + if (!TEST_true(i & DH_CHECK_INVALID_Q_VALUE) + || !TEST_false(i & DH_CHECK_Q_NOT_PRIME)) + goto err3; + /* Modulus of size: dh check max modulus bits + 1 */ if (!TEST_true(BN_set_word(p, 1)) || !TEST_true(BN_lshift(p, p, OPENSSL_DH_CHECK_MAX_MODULUS_BITS))) @@ -134,6 +143,9 @@ static int dh_test(void) if (!TEST_false(DH_check(dh, &i))) goto err3; + /* We'll have a stale error on the queue from the above test so clear it */ + ERR_clear_error(); + /* * II) key generation */ |