diff options
author | Damien Miller <djm@mindrot.org> | 2012-02-11 08:16:28 +1100 |
---|---|---|
committer | Damien Miller <djm@mindrot.org> | 2012-02-11 08:16:28 +1100 |
commit | 2ec0342ed4f1fcf4d7b140f9d91bc97c8025221a (patch) | |
tree | f92da16e93c9388f4f5777fc22bbd1349ff1f1d3 | |
parent | a2876db5e6a26c48bd2a20a9f347a1e668730845 (diff) |
- djm@cvs.openbsd.org 2012/01/07 21:11:36
[mux.c]
fix double-free in new session handler
-rw-r--r-- | ChangeLog | 3 | ||||
-rw-r--r-- | mux.c | 6 |
2 files changed, 5 insertions, 4 deletions
@@ -3,6 +3,9 @@ - djm@cvs.openbsd.org 2012/01/05 00:16:56 [monitor.c] memleak on error path + - djm@cvs.openbsd.org 2012/01/07 21:11:36 + [mux.c] + fix double-free in new session handler 20120206 - (djm) [ssh-keygen.c] Don't fail in do_gen_all_hostkeys on platforms @@ -1,4 +1,4 @@ -/* $OpenBSD: mux.c,v 1.33 2011/12/04 23:16:12 djm Exp $ */ +/* $OpenBSD: mux.c,v 1.34 2012/01/07 21:11:36 djm Exp $ */ /* * Copyright (c) 2002-2008 Damien Miller <djm@openbsd.org> * @@ -341,10 +341,8 @@ process_mux_new_session(u_int rid, Channel *c, Buffer *m, Buffer *r) env_len = 0; while (buffer_len(m) > 0) { #define MUX_MAX_ENV_VARS 4096 - if ((cp = buffer_get_string_ret(m, &len)) == NULL) { - xfree(cmd); + if ((cp = buffer_get_string_ret(m, &len)) == NULL) goto malf; - } if (!env_permitted(cp)) { xfree(cp); continue; |