From 9589b217af20e48429f87eb22ce7510e59bd7671 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Thu, 30 Dec 2021 13:40:47 +0100 Subject: prometheus-node-exporter: Remove backslashes in ExecStart script According to 41c6d7adfcad4ed4fc6f22140ab6c4285348d89c and https://github.com/NixOS/nixpkgs/issues/63533 having backslashes prevents systemd from successfully parsing the unit file and therefore results in prometheus-node-exporter not starting. This patch removes the backslashes from the ExecStart script. Signed-off-by: Matthias Beyer --- .../modules/services/monitoring/prometheus/exporters/node.nix | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/nixos/modules/services/monitoring/prometheus/exporters/node.nix b/nixos/modules/services/monitoring/prometheus/exporters/node.nix index 5e5fc7cd5524..d7579c199476 100644 --- a/nixos/modules/services/monitoring/prometheus/exporters/node.nix +++ b/nixos/modules/services/monitoring/prometheus/exporters/node.nix @@ -29,11 +29,12 @@ in serviceConfig = { DynamicUser = false; RuntimeDirectory = "prometheus-node-exporter"; - ExecStart = '' - ${pkgs.prometheus-node-exporter}/bin/node_exporter \ - ${concatMapStringsSep " " (x: "--collector." + x) cfg.enabledCollectors} \ - ${concatMapStringsSep " " (x: "--no-collector." + x) cfg.disabledCollectors} \ - --web.listen-address ${cfg.listenAddress}:${toString cfg.port} ${concatStringsSep " " cfg.extraFlags} + ExecStart = let + enabledCollectors = concatMapStringsSep " " (x: "--collector." + x) cfg.enabledCollectors; + disabledCollectors = concatMapStringsSep " " (x: "--no-collector." + x) cfg.disabledCollectors; + listenAddr = "--web.listen-address ${cfg.listenAddress}:${toString cfg.port} ${concatStringsSep " " cfg.extraFlags}"; + in '' + ${pkgs.prometheus-node-exporter}/bin/node_exporter ${enabledCollectors} ${disabledCollectors} ${listenAddr} ''; RestrictAddressFamilies = optionals (any (collector: (collector == "logind" || collector == "systemd")) cfg.enabledCollectors) [ # needs access to dbus via unix sockets (logind/systemd) -- cgit v1.2.3