diff options
| author | Varun Patil <varunpatil@ucla.edu> | 2023-10-16 21:04:53 -0700 |
|---|---|---|
| committer | John Molakvoæ <skjnldsv@protonmail.com> | 2024-01-15 09:48:57 +0100 |
| commit | b997c7de108ea6c90f6ef359c773c1586286a7e8 (patch) | |
| tree | ec66a364c14e07570cab588e501bc66062536763 | |
| parent | b768934478c53bb888f5b93ce3bb733d3912d77f (diff) | |
sidebar: allow turning off tags view by defaultbackport/40939/stable28
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
[skip ci]
| -rw-r--r-- | apps/files/src/sidebar.js | 1 | ||||
| -rw-r--r-- | apps/files/src/views/Sidebar.vue | 14 |
2 files changed, 13 insertions, 2 deletions
diff --git a/apps/files/src/sidebar.js b/apps/files/src/sidebar.js index c8bfc2ca4db..ceec5478466 100644 --- a/apps/files/src/sidebar.js +++ b/apps/files/src/sidebar.js @@ -59,4 +59,5 @@ window.addEventListener('DOMContentLoaded', function() { window.OCA.Files.Sidebar.open = AppSidebar.open window.OCA.Files.Sidebar.close = AppSidebar.close window.OCA.Files.Sidebar.setFullScreenMode = AppSidebar.setFullScreenMode + window.OCA.Files.Sidebar.setShowTagsDefault = AppSidebar.setShowTagsDefault }) diff --git a/apps/files/src/views/Sidebar.vue b/apps/files/src/views/Sidebar.vue index d0c6b90b49d..7b958aca312 100644 --- a/apps/files/src/views/Sidebar.vue +++ b/apps/files/src/views/Sidebar.vue @@ -36,7 +36,7 @@ <!-- TODO: create a standard to allow multiple elements here? --> <template v-if="fileInfo" #description> <div class="sidebar__description"> - <SystemTags v-if="isSystemTagsEnabled" + <SystemTags v-if="isSystemTagsEnabled && showTagsDefault" v-show="showTags" :file-id="fileInfo.id" @has-tags="value => showTags = value" /> @@ -138,6 +138,7 @@ export default { // reactive state Sidebar: OCA.Files.Sidebar.state, showTags: false, + showTagsDefault: true, error: null, loading: true, fileInfo: null, @@ -455,7 +456,7 @@ export default { * Toggle the tags selector */ toggleTags() { - this.showTags = !this.showTags + this.showTagsDefault = this.showTags = !this.showTags }, /** @@ -530,6 +531,15 @@ export default { }, /** + * Allow to set whether tags should be shown by default from OCA.Files.Sidebar + * + * @param {boolean} showTagsDefault - Whether or not to show the tags by default. + */ + setShowTagsDefault(showTagsDefault) { + this.showTagsDefault = showTagsDefault + }, + + /** * Emit SideBar events. */ handleOpening() { |