diff options
| author | Fabio Leandro Janiszevski <fabiosammy@gmail.com> | 2024-06-06 06:00:09 -0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-06 09:00:09 +0000 |
| commit | cd4b00810d49bb95b6421c84d48a6e075a18486c (patch) | |
| tree | 79c879361519b8ffbedb721637d3e1859ce21064 | |
| parent | a729104a4159106f959bcc9b3ab438d2876ce9a5 (diff) | |
Clear the docker setup - Deprecate post-create.sh and use bin/setup (#30502)
| -rw-r--r-- | .devcontainer/codespaces/devcontainer.json | 2 | ||||
| -rw-r--r-- | .devcontainer/devcontainer.json | 2 | ||||
| -rwxr-xr-x | .devcontainer/post-create.sh | 27 | ||||
| -rw-r--r-- | README.md | 2 |
4 files changed, 3 insertions, 30 deletions
diff --git a/.devcontainer/codespaces/devcontainer.json b/.devcontainer/codespaces/devcontainer.json index ca9156fdaa4..6736734e606 100644 --- a/.devcontainer/codespaces/devcontainer.json +++ b/.devcontainer/codespaces/devcontainer.json @@ -37,7 +37,7 @@ }, "onCreateCommand": "git config --global --add safe.directory ${containerWorkspaceFolder}", - "postCreateCommand": ".devcontainer/post-create.sh", + "postCreateCommand": "bin/setup", "waitFor": "postCreateCommand", "customizations": { diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 2c53be9c77c..4a9cf11cc2b 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -30,7 +30,7 @@ }, "onCreateCommand": "git config --global --add safe.directory ${containerWorkspaceFolder}", - "postCreateCommand": ".devcontainer/post-create.sh", + "postCreateCommand": "bin/setup", "waitFor": "postCreateCommand", "customizations": { diff --git a/.devcontainer/post-create.sh b/.devcontainer/post-create.sh deleted file mode 100755 index 82a2ccbb6ce..00000000000 --- a/.devcontainer/post-create.sh +++ /dev/null @@ -1,27 +0,0 @@ -#!/bin/bash - -set -e # Fail the whole script on first error - -# Fetch Ruby gem dependencies -bundle config path 'vendor/bundle' -bundle config with 'development test' -bundle install - -# Make Gemfile.lock pristine again -git checkout -- Gemfile.lock - -# Fetch Javascript dependencies -corepack prepare -yarn install --immutable - -# [re]create, migrate, and seed the test database -RAILS_ENV=test ./bin/rails db:setup - -# [re]create, migrate, and seed the development database -RAILS_ENV=development ./bin/rails db:setup - -# Precompile assets for development -RAILS_ENV=development ./bin/rails assets:precompile - -# Precompile assets for test -RAILS_ENV=test ./bin/rails assets:precompile diff --git a/README.md b/README.md index 45291d63780..3773b647fea 100644 --- a/README.md +++ b/README.md @@ -107,7 +107,7 @@ development environment with **Docker**, complete the following steps: - Install Docker Desktop - Run `docker compose -f .devcontainer/docker-compose.yml up -d` -- Run `docker compose -f .devcontainer/docker-compose.yml exec app .devcontainer/post-create.sh` +- Run `docker compose -f .devcontainer/docker-compose.yml exec app bin/setup` - Finally, run `docker compose -f .devcontainer/docker-compose.yml exec app bin/dev` If you are using an IDE with [support for the Development Container specification](https://containers.dev/supporting), it will run the above `docker compose` commands automatically. For **Visual Studio Code** this requires the [Dev Container extension](https://containers.dev/supporting#dev-containers). |