From b07e5198b552a84d20e7bfef2b6d915ce043d95a Mon Sep 17 00:00:00 2001 From: Wilfred Hughes Date: Sun, 8 Oct 2023 15:40:39 -0700 Subject: Remove prebuilt musl binaries in release config --- .github/workflows/release.yml | 9 ++++++--- CHANGELOG.md | 10 ++++++++++ 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 66e7cb8d0..1ba37a2a0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,8 +34,12 @@ jobs: # Targets using cross-compilation (upload-rust-binary-action # detects that they need cross). - - target: x86_64-unknown-linux-musl - os: ubuntu-20.04 + + # TODO: fix musl so it statically links during release, see + # https://github.com/Wilfred/difftastic/issues/563 + # + # - target: x86_64-unknown-linux-musl + # os: ubuntu-20.04 - target: aarch64-unknown-linux-gnu os: ubuntu-20.04 - target: aarch64-apple-darwin @@ -63,4 +67,3 @@ jobs: - uses: katyo/publish-crates@v1 with: registry-token: ${{ secrets.CARGO_REGISTRY_TOKEN }} - diff --git a/CHANGELOG.md b/CHANGELOG.md index 34e26c43e..3d4408589 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,16 @@ values are constructed, such as `Foo {}`). Improved syntax highlighting for C#. +### Build + +This release does not provide a prebuilt musl binary, due +to [a dynamic linking +issue](https://github.com/Wilfred/difftastic/issues/563) with binaries +in the release script. + +musl remains tested in CI and supported for users, but you will need +to compile difftastic from source. + ## 0.51.1 (released 25th August 2023) Fixed an issue with GitHub actions that prevented prebuilt binaries -- cgit v1.2.3