diff options
| author | Brian Chen <brianc118@fb.com> | 2022-02-15 09:41:56 -0800 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2022-02-15 09:45:29 -0800 |
| commit | 2e448d4884f656234da9c59ba6aeb02ab59ff823 (patch) | |
| tree | 3912b92b8bb01b4a7e1fbcdfce06545c01394ba7 | |
| parent | f24bb7aba674e72cd35997e7fa5a573e08482193 (diff) | |
Don't read disks stats when it's turned off
Summary:
We are still reading disk stats when collection is turned off, except
we just don't save it to the sample/model. Let's stop reading
altogether.
Reviewed By: lnyng
Differential Revision: D34191764
fbshipit-source-id: 2329f26dda0848568b4cdafdd24389b7b0808e98
| -rw-r--r-- | below/model/src/collector.rs | 33 |
1 files changed, 17 insertions, 16 deletions
diff --git a/below/model/src/collector.rs b/below/model/src/collector.rs index 81b09a0d..fefe3ecb 100644 --- a/below/model/src/collector.rs +++ b/below/model/src/collector.rs @@ -202,23 +202,24 @@ pub fn collect_sample( None } }, - disks: match (disable_disk_stat, reader.read_disk_stats_and_fsinfo()) { - (false, Ok(disks)) => disks - .into_iter() - .map(|(disk_name, disk_stat)| (disk_name, disk_stat.into())) - .filter(|(disk_name, disk_stat)| { - if disk_name.starts_with("ram") || disk_name.starts_with("loop") { - return false; - } - - !is_all_zero_disk_stats(&disk_stat) - }) - .collect(), - (false, Err(e)) => { - error!(logger, "{:#}", e); - Default::default() + disks: if disable_disk_stat { + Default::default() + } else { + match reader.read_disk_stats_and_fsinfo() { + Ok(disks) => disks + .into_iter() + .filter(|(disk_name, disk_stat)| { + if disk_name.starts_with("ram") || disk_name.starts_with("loop") { + return false; + } + !is_all_zero_disk_stats(disk_stat) + }) + .collect(), + Err(e) => { + error!(logger, "{:#}", e); + Default::default() + } } - (true, _) => Default::default(), }, }, }) |